From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932720AbdJaSQo (ORCPT ); Tue, 31 Oct 2017 14:16:44 -0400 Received: from mail-bn3nam01on0058.outbound.protection.outlook.com ([104.47.33.58]:5624 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752908AbdJaSQm (ORCPT ); Tue, 31 Oct 2017 14:16:42 -0400 From: "Madhani, Himanshu" To: Bart Van Assche CC: "martin.petersen@oracle.com" , "keescook@chromium.org" , "jejb@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Dept-Eng QLA2xxx Upstream Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Topic: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Index: AQHTTXkYGo0ktCcFY0ucpeQkciWZRaL+JN91gAAlXQCAAAJvgIAAASsA Date: Tue, 31 Oct 2017 18:16:39 +0000 Message-ID: <3CE2B08B-07F4-411D-B87A-18F586F5534C@cavium.com> References: <20171025100737.GA145097@beast> <16733DFA-7339-4F77-9125-E8845C4FCD6F@cavium.com> <1509473546.12927.5.camel@wdc.com> In-Reply-To: <1509473546.12927.5.camel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR07MB3455;6:WOff3t4rGieK2I9rt8QcuYrqcat2umoW4dTdWfeTng720ddf4mNirhyneRFoPBaB/p5N1grlNMVlDn/31Zt0VqnHYUqW+pS2iHNnfdW4M3UDeEqYC7JmqgpJ0/ffJjadriKqrthhva6qrGugbHq2Z5hHx6ZtORAkn+a1NegavvoIOz02isY/zB1zI5RXtexUISKHmD6kSGaKHUt2RQje+BGsSfJpZELHi66iF/RLbFsFSWz9n4dWKAQgM1tVFfO4PWkNsWgGNaV3bP+g9R9fib/VWvWwC8Vjy9OYpz0WLhJFkGclfsYULnMPCTkbi9HUngll5QPz3Cp9xbZGOnbfPK3K5mDPUT+7PfZskqSY3v0=;5:ECilkI+Zn/Hj3MmoZdvWNUyd60I/tvVcw2cHXfdKeYUgT4UhJB+ms8gXpgIW+Lr3bdveHnrhsf2QgM/84ueg8qzJa9Wy68vepRZSWpcC+LZ+jW2DdsXaTMF1ETDMzfWXqtdV++zMXmhd1chTbcXhyUufU3Qb6VVI1IaKmQFAKUA=;24:mHOXKl2f3XY32XA1EAHxSjwLJwYWnD80J4RTaekBfuuMkr7HgORYHOxYvlNV6Xo/M118znbedij4yp8lFJZ/HxkBRIUeCSyTIU3Hy5gH+8E=;7:4dVmEAH3w9O/1hlISAYtpOrYXqsh6CgH6x8vBqFUjxlUCKvn+iwfgUVYG4Bt5DSPJ3zeLsZEAg2PY6khIMlP8Xjui0K50b6UzMDRwn2JYqpGBlzRC5lpsQRgwliarBsXA3VhYsdr2B/Y1Ecr8Zbbrd+RiRLBwNcDt6Ydry+25KPYcYZi1J0nEXyZVJAr75g65B1Tke7UEUX3+JQTLetRwenQAJVFhVK6pS2I63goqOwZ615GRQDlqzQG//x5Ql9r x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 57c0a32d-469a-4b62-b432-08d5208b87e7 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:MWHPR07MB3455; x-ms-traffictypediagnostic: MWHPR07MB3455: x-exchange-antispam-report-test: UriScan:(146099531331640); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231020)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3455;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3455; x-forefront-prvs: 04772EA191 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(52314003)(189002)(377424004)(199003)(24454002)(68736007)(6436002)(54356999)(97736004)(76176999)(6486002)(478600001)(2900100001)(77096006)(6506006)(50986999)(102836003)(3846002)(82746002)(4001150100001)(33656002)(6116002)(4326008)(6246003)(107886003)(36756003)(83716003)(72206003)(229853002)(101416001)(53546010)(189998001)(305945005)(14454004)(93886005)(6512007)(3280700002)(86362001)(6916009)(2950100002)(25786009)(53936002)(99286003)(316002)(54906003)(8676002)(106356001)(8936002)(105586002)(3660700001)(66066001)(7736002)(2906002)(5660300001)(81166006)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3455;H:MWHPR07MB3455.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57c0a32d-469a-4b62-b432-08d5208b87e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2017 18:16:39.4039 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3455 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9VIH3Ah023286 Hi Bart, > On Oct 31, 2017, at 11:12 AM, Bart Van Assche wrote: > > On Tue, 2017-10-31 at 18:03 +0000, Madhani, Himanshu wrote: >> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen wrote: >>>> In preparation for unconditionally passing the struct timer_list >>>> pointer to all timer callbacks, switch to using the new timer_setup() >>>> and from_timer() to pass the timer pointer explicitly. >>> >>> Cavium folks: Please verify! >> >> I’ve checked on my setup and i am seeing regression with this patch applied. >> >> Driver load locks up the system with this patch applied. >> >> NACK > > That feedback is not very helpful … > Here’s my setup details 4.14.0-rc7 + scsi_misc-4.15 qla2xxx patches from Martin’s tree + current patch. System has 3 adapters 8G/16G/32G. > Anyway, what kernel source tree did you use in your testing? I may be able to > free up some time to look into this myself. > > Bart. Thanks, - Himanshu