mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcin Dalecki <dalecki@evision.ag>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Samuel Thibault <samuel.thibault@fnac.net>,
	martin@dalecki.de, alan@lxorguk.ukuu.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/ide/qd65xx: no cli/sti (2.4.19-pre3 & 2.5.28)
Date: Thu, 25 Jul 2002 10:25:26 +0200	[thread overview]
Message-ID: <3D3FB5F6.3060000@evision.ag> (raw)
In-Reply-To: <20020725093154.A21541@ucw.cz>

Vojtech Pavlik wrote:
> On Thu, Jul 25, 2002 at 01:45:00AM +0200, Samuel Thibault wrote:
> 
>>Hello,
>>
>>Here are patches for 2.4.19-pre3 & 2.5.28 which free them from using
>>cli/sti in qd65xx stuff.
> 
> 
> Cool.
> 
> 
>>(also using ide's OUT_BYTE / IN_BYTE btw)
> 
> 
> In my opinion this doesn't make sense. The qd65xx is a VESA Local Bus
> only hardware and is very very unlikely to be used on anything else than
> an x86, where these defines are needed. Also, the ports written to are
> not a part of the IDE controller region, so the IN_BYTE/OUT_BYTE macros
> might not work there if it was ever used on a non-x86 machine. Also, it
> makes the code less readable.

Amen. BTW> I think proper fix is to simple *remove* the cli() cti()
commands. They don't make much sense in first place.


  reply	other threads:[~2002-07-25  8:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.44.0205260248160.17222-400000@youpi.residence.ens-lyon.fr>
2002-07-24 23:45 ` Samuel Thibault
2002-07-25  7:31   ` Vojtech Pavlik
2002-07-25  8:25     ` Marcin Dalecki [this message]
2002-07-25  8:52       ` Vojtech Pavlik
2002-07-25 15:15         ` Samuel Thibault
2002-07-25 15:47           ` Zwane Mwaikambo
2002-07-25 17:26             ` Samuel Thibault
     [not found] <Pine.LNX.4.10.10207241643430.4719-100000@master.linux-ide.org>
2002-07-25 13:07 ` Samuel Thibault
2002-07-25 13:16   ` Andre Hedrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D3FB5F6.3060000@evision.ag \
    --to=dalecki@evision.ag \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@dalecki.de \
    --cc=samuel.thibault@fnac.net \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®