mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Brian Gerst <bgerst@quark.didntduck.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Dead code in i386/kernel/process.c
Date: Sat, 03 Aug 2002 19:09:25 -0400	[thread overview]
Message-ID: <3D4C62A5.8040607@quark.didntduck.org> (raw)
In-Reply-To: <3D4C5B8E.5060009@quark.didntduck.org>

Brian Gerst wrote:
> This patch removes an artifact of code left over from the 2.0 days when 
> the kernel didn't use flat segments.
> 
> 
> ------------------------------------------------------------------------
> 
> diff -urN linux-2.5.30/arch/i386/kernel/process.c linux/arch/i386/kernel/process.c
> --- linux-2.5.30/arch/i386/kernel/process.c	Fri Aug  2 10:15:28 2002
> +++ linux/arch/i386/kernel/process.c	Sat Aug  3 16:41:03 2002
> @@ -313,11 +313,6 @@
>  	memcpy (swapper_pg_dir, swapper_pg_dir + USER_PGD_PTRS,
>  		sizeof (swapper_pg_dir [0]) * KERNEL_PGD_PTRS);
>  
> -	/* Make sure the first page is mapped to the start of physical memory.
> -	   It is normally not mapped, to trap kernel NULL pointer dereferences. */
> -
> -	pg0[0] = _PAGE_RW | _PAGE_PRESENT;
> -
>  	/*
>  	 * Use `swapper_pg_dir' as our page directory.
>  	 */

I should clarify that the dead code does the same thing as the preceding 
memcpy.


  reply	other threads:[~2002-08-03 23:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-03 22:39 Brian Gerst
2002-08-03 23:09 ` Brian Gerst [this message]
2002-08-04 15:45 ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D4C62A5.8040607@quark.didntduck.org \
    --to=bgerst@quark.didntduck.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®