Hello, I am working on a patch that removes the old limit of NGROUPS. In doing so, I am checking everything that references NGROUPS. One such place is in arch/s390x/kernel/linux32.c. I notice these things: * s390x defines __kernel_old_gid_t to __kernel_gid_t (unsigned int) * s390x has a sys32_getgroups16() which looks JUST LIKE uid16.c sys_getgroups16 * s390x does not define CONFIG_UID16, but seems to need it It seems to me that if we do: * s390x defines CONFIG_UID16 * typedef __kernel_old_gid_t to u16 * get rid of all the sys32_*16 stuff and just call the uid16.c function We could save a bit of duplicated code. Patches that remove code are good, right? Obviouscly, I can't test it. Please - comments? Shoot me down if I have missed something. What I know of s390 can fit inside a thimble. 2.4.x patch attached, 2.5.x to follow, if this is ok (whether it goes into 2.4.x or not, I did this version first) Tim -- Tim Hockin Systems Software Engineer Sun Microsystems, Linux Kernel Engineering thockin@sun.com