From: Andrew Morton <akpm@zip.com.au>
To: Andre Hedrick <andre@linux-ide.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: /pub/linux/kernel/people/hedrick/ide-2.5.32
Date: Thu, 29 Aug 2002 12:57:47 -0700 [thread overview]
Message-ID: <3D6E7CBB.407299E3@zip.com.au> (raw)
In-Reply-To: <Pine.LNX.4.10.10208291240560.24156-100000@master.linux-ide.org>
Andre Hedrick wrote:
>
> ...
> There is one more thing to fix.
>
> ./fs/mpage.c
>
> /*
> * The largest-sized BIO which this code will assemble, in bytes. Set this
> * to PAGE_CACHE_SIZE if your drivers are broken.
> */
> #define MPAGE_BIO_MAX_SIZE 32768 //BIO_MAX_SIZE
>
> This is confirmed with Al Viro and was required to make things sane!
You'll need to do the same thing to fs/direct-io.c:DIO_BIO_MAX_SIZE
in that case.
I'd suggest that you just go in and change BIO_MAX_SECTORS
to 64. Or 32 if you happen to be using a qlogic controller :(
So everything's broken in there - a hardwired constant doesn't
cut it. Jens is cooking up an `add_page_to_bio()' API which
will do the right thing based upon q->max_sectors. But that
is not yet available.
next prev parent reply other threads:[~2002-08-29 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-29 19:46 /pub/linux/kernel/people/hedrick/ide-2.5.32 Andre Hedrick
2002-08-29 19:57 ` Andrew Morton [this message]
2002-08-29 20:02 ` /pub/linux/kernel/people/hedrick/ide-2.5.32 Andre Hedrick
2002-08-29 20:35 ` /pub/linux/kernel/people/hedrick/ide-2.5.32 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D6E7CBB.407299E3@zip.com.au \
--to=akpm@zip.com.au \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®