From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: "David S. Miller" <davem@redhat.com>
Cc: steve@neptune.ca, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.20-pre6 tg3 compile errors
Date: Wed, 11 Sep 2002 09:36:46 -0400 [thread overview]
Message-ID: <3D7F46EE.4040905@mandrakesoft.com> (raw)
In-Reply-To: <20020911.062510.00773243.davem@redhat.com>
David S. Miller wrote:
> From: Jeff Garzik <jgarzik@mandrakesoft.com>
> Date: Tue, 10 Sep 2002 22:37:25 -0400
>
> Wrap this line of code inside a
>
> #if TG3_VLAN_TAG_USED
> ...line 4881 here...
> #endif
>
> Not sufficient, you need to have an "#else" clause that
> sets RX_MODE_KEEP_VLAN_TAG all the time.
So IOW what I said was correct, but Steve's patch was wrong :)
You don't need a #else clause because line 4882 sets
RX_MODE_KEEP_VLAN_TAG unconditionally, if you #ifdef out line 4881.
Jeff
next prev parent reply other threads:[~2002-09-11 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-10 21:12 Linux 2.4.20-pre6 Tony Spinillo
2002-09-10 21:19 ` Linux 2.4.20-pre6 tg3 compile errors Steve Mickeler
2002-09-10 21:21 ` David S. Miller
2002-09-10 21:33 ` Steve Mickeler
2002-09-10 21:26 ` David S. Miller
2002-09-11 2:20 ` Steve Mickeler
2002-09-11 2:37 ` Jeff Garzik
2002-09-11 2:56 ` Steve Mickeler
2002-09-11 13:25 ` David S. Miller
2002-09-11 13:36 ` Jeff Garzik [this message]
2002-09-11 13:23 ` David S. Miller
2002-09-10 21:28 ` Jeff Garzik
2002-09-10 21:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D7F46EE.4040905@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@neptune.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®