From: Oleg Nesterov <oleg@tv-sign.ru>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>
Subject: [UPATCH] force_sig_info()
Date: Sun, 29 Sep 2002 16:52:01 +0400 [thread overview]
Message-ID: <3D96F771.E6D7B2B0@tv-sign.ru> (raw)
Hello.
This is my third attempt:
On Mon, 16 Sep 2002, Oleg Nesterov wrote:
> 2.5.34 introduced this change in force_sig_info()
>
> - return send_sig_info(sig, info, t);
> + return send_sig_info(sig, (void *)1, t);
>
> I beleive, it is wrong, info can carry useful information
> from do_page_fault, traps. And this (info *)1 does not
> prevent send_signal() from allocation of siginfo struct.
> Ingo, could you please clarify?
Call me stupid, but i still believe it is bug.
--- linux-2.5.39/kernel/signal.c~ Sun Sep 29 16:37:08 2002
+++ linux-2.5.39/kernel/signal.c Sun Sep 29 16:37:35 2002
@@ -781,7 +781,7 @@
recalc_sigpending_tsk(t);
spin_unlock_irqrestore(&t->sigmask_lock, flags);
- return send_sig_info(sig, (void *)1, t);
+ return send_sig_info(sig, info, t);
}
static int
Oleg.
next reply other threads:[~2002-09-29 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 12:52 Oleg Nesterov [this message]
2002-09-29 13:07 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D96F771.E6D7B2B0@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®