Received: from localhost (nighthawk [127.0.0.1]) by nighthawk.sr71.net (8.11.6/8.11.6) with ESMTP id g9B19MU01846 for ; Thu, 10 Oct 2002 18:09:22 -0700 Received: from imap.linux.ibm.com [9.27.103.44] by localhost with IMAP (fetchmail-5.9.0) for dave@localhost (multi-drop); Thu, 10 Oct 2002 18:09:22 -0700 (PDT) Received: from localhost ([unix socket]) by imap.linux.ibm.com (Cyrus v2.1.9) with LMTP; Thu, 10 Oct 2002 21:09:26 -0400 X-Sieve: CMU Sieve 2.2 Received: from smtp.linux.ibm.com (linux.ibm.com [9.26.4.197]) by imap.linux.ibm.com (Postfix) with ESMTP id A15D57C017 for ; Thu, 10 Oct 2002 21:09:25 -0400 (EDT) Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com [9.56.224.206]) by smtp.linux.ibm.com (Postfix) with ESMTP id 04B4F3FE06 for ; Thu, 10 Oct 2002 21:09:25 -0400 (EDT) Received: from e2.ny.us.ibm.com (e2.esmtp.ibm.com [9.14.6.102]) by northrelay04.pok.ibm.com (8.12.3/NCO/VER6.4) with ESMTP id g9B19IKf137968 for ; Thu, 10 Oct 2002 21:09:22 -0400 Received: from pogo.mtv1.steeleye.com (host194.steeleye.com [66.206.164.34]) by e2.ny.us.ibm.com (8.12.2/8.12.2) with ESMTP id g9B19KHd065956 for ; Thu, 10 Oct 2002 21:09:20 -0400 Received: (from root@localhost) by pogo.mtv1.steeleye.com (8.9.3/8.9.3) id SAA07896 for ; Thu, 10 Oct 2002 18:09:19 -0700 Received: from localhost.localdomain (vpn-233.mtv1.steeleye.com [172.16.1.233]) by pogo.mtv1.steeleye.com (8.9.3/8.9.3) with ESMTP id SAA07617; Thu, 10 Oct 2002 18:09:16 -0700 Received: from mulgrave (jejb@localhost) by localhost.localdomain (8.11.6/linuxconf) with ESMTP id g9B19FJ14530; Thu, 10 Oct 2002 18:09:16 -0700 Message-Id: <200210110109.g9B19FJ14530@localhost.localdomain> X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 To: Dave Hansen Cc: linux-scsi@vger.kernel.org Subject: Re: Degraded I/O performance, since 2.5.41 In-Reply-To: Message from Dave Hansen of "Thu, 10 Oct 2002 16:48:47 PDT." <3DA611DF.3000206@us.ibm.com> Mime-Version: 1.0 Content-Type: multipart/mixed ; boundary="==_Exmh_-5647072960" Date: Thu, 10 Oct 2002 18:09:14 -0700 From: James Bottomley X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (http://amavis.org/) X-Spam-Status: No, hits=-7.3 required=5.0 tests=IN_REP_TO,DOUBLE_CAPSWORD,UNIFIED_PATCH version=2.31 X-Spam-Level: X-Fetchmail-Warning: no recipient addresses matched declared local names This is a multipart MIME message. --==_Exmh_-5647072960 Content-Type: text/plain; charset=us-ascii OK, this patch should fix it. Do your performance numbers for ips improve again with this? James --==_Exmh_-5647072960 Content-Type: text/plain ; name="tmp.diff"; charset=us-ascii Content-Description: tmp.diff Content-Disposition: attachment; filename="tmp.diff" ===== drivers/scsi/scsi_scan.c 1.24 vs edited ===== --- 1.24/drivers/scsi/scsi_scan.c Tue Oct 8 15:45:57 2002 +++ edited/drivers/scsi/scsi_scan.c Thu Oct 10 17:40:53 2002 @@ -1477,11 +1477,14 @@ if (sdt->detect) sdev->attached += (*sdt->detect) (sdev); - if (sdev->host->hostt->slave_attach != NULL) + if (sdev->host->hostt->slave_attach != NULL) { if (sdev->host->hostt->slave_attach(sdev) != 0) { printk(KERN_INFO "scsi_add_lun: failed low level driver attach, setting device offline"); sdev->online = FALSE; } + } else if(sdev->host->cmd_per_lun) { + scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun); + } if (sdevnew != NULL) *sdevnew = sdev; --==_Exmh_-5647072960--