From: Greg Ungerer <gerg@snapgear.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: linux-2.5.44uc1 (MMU-less support)
Date: Mon, 28 Oct 2002 00:15:07 +1000 [thread overview]
Message-ID: <3DBBF4EB.7030406@snapgear.com> (raw)
In-Reply-To: <20021026201856.GA1670@mars.ravnborg.org>
Hi Sam,
Sam Ravnborg wrote:
> On Sun, Oct 27, 2002 at 02:19:38AM +1000, Greg Ungerer wrote:
>
>> - arch Makefiles rewritten
>
> Took a look at them.
> See comments below.
Thanks.
Rolled on these in to the next patch set.
Had to make one small adjustment:
> +
> +arch/$(ARCH)/kernel/asm-offsets.s: include/asm include/linux/version.h \
> + include/config/MARKER
> +
> +include/asm-$(ARCH)/asm-offsets.h.tmp: arch/$(ARCH)/kernel/asm-offsets.s
> + @$(generate-asm-offsets.h) < $< > $@
> +
> +include/asm-$(ARCH)/asm-offsets.h: include/asm-$(ARCH)/asm-offsets.h.tmp
> + @echo -n ' Generating $@'
> + @$(update-if-changed)
> Combine it like this instead:
> include/asm-$(ARCH)/asm-offsets.h: arch/$(ARCH)/kernel/asm-offsets.s \
> include/asm include/linux/version.h \
> include/config/MARKER
> @echo -n ' Generating $@'
> @$(generate-asm-offsets.h) < $< > $@
^^^
This needs to be $@.tmp, "update-if-changed" specifically looks
for the .tmp named file.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Wizard EMAIL: gerg@snapgear.com
Snapgear Pty Ltd PHONE: +61 7 3279 1822
825 Stanley St, FAX: +61 7 3279 1820
Woolloongabba, QLD, 4102, Australia WEB: www.SnapGear.com
next prev parent reply other threads:[~2002-10-27 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-26 16:19 Greg Ungerer
2002-10-26 20:18 ` Sam Ravnborg
2002-10-27 14:15 ` Greg Ungerer [this message]
2002-10-28 3:53 ` Miles Bader
2002-10-28 4:13 ` Miles Bader
2002-10-28 5:11 ` Greg Ungerer
[not found] <fa.fd5mvtv.9gon33@ifi.uio.no>
2002-10-27 4:04 ` Miles Bader
2002-10-27 7:48 ` Sam Ravnborg
2002-10-27 11:15 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DBBF4EB.7030406@snapgear.com \
--to=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome