mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp
Date: Fri, 25 Jan 2019 08:56:46 +0100	[thread overview]
Message-ID: <3DC0DB52-E3B0-42F3-BD4D-913FD77EDFBB@holtmann.org> (raw)
In-Reply-To: <20190124180724.20910-1-malat@debian.org>

Hi Mathieu,

> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
> 
> This commit removes the following warning:
> 
>  net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> net/bluetooth/l2cap_core.c | 1 +
> 1 file changed, 1 insertion(+)

the patches don’t apply cleanly against bluetooth-next tree. Please fix it up and resend.

Regards

Marcel


  parent reply	other threads:[~2019-01-25  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 18:07 Mathieu Malaterre
2019-01-24 18:07 ` [PATCH 2/2] Bluetooth: Correctly annotate implicit fall through in __rfcomm_dlc_close Mathieu Malaterre
2019-01-25  8:09   ` Mathieu Malaterre
2019-01-25  7:56 ` Marcel Holtmann [this message]
2019-01-25  8:08   ` [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp Mathieu Malaterre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DC0DB52-E3B0-42F3-BD4D-913FD77EDFBB@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=davem@davemloft.net \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malat@debian.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®