From: Jeff Garzik <jgarzik@pobox.com>
To: Zwane Mwaikambo <zwane@holomorphy.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, Dave Jones <davej@suse.de>
Subject: Re: [PATCH][2.5] xircom_cb small cleanups
Date: Sat, 30 Nov 2002 14:35:18 -0500 [thread overview]
Message-ID: <3DE912F6.5090306@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0211122134430.24523-100000@montezuma.mastecende.com>
Patch looks basically ok, but you should get together with Dave Jones
and come up with a unified patch that also eliminates the
private=kmalloc allocation by filling in init_etherdev's 2nd argument.
Both init_etherdev and alloc_etherdev allocate struct net_device* and
dev->priv in a single allocation. As an additional bonus, dev->priv is
aligned on a 32-byte [not bit] boundary, and the entire area is zeroed
with memset()
Jeff
prev parent reply other threads:[~2002-11-30 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-13 2:37 Zwane Mwaikambo
2002-11-30 19:35 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DE912F6.5090306@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome