From: Jeff Garzik <jgarzik@pobox.com>
To: Bernd Eckenfels <ecki@calista.eckenfels.6bone.ka-ip.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] C99 initializers for drivers/media/radio
Date: Sat, 30 Nov 2002 16:06:28 -0500 [thread overview]
Message-ID: <3DE92854.6000000@pobox.com> (raw)
In-Reply-To: <E18IEk7-0003yA-00@calista.inka.de>
Bernd Eckenfels wrote:
> In article <20021130174509.GD10613@debian> you wrote:
>
>>Here's a patch set for switching drivers/media/radio to use C99
>>initializers. The patches are against 2.5.50.
>
> ...
>
>>static struct pcm20_device pcm20_unit = {
>>- freq: 87*16000,
>>- muted: 1,
>>- stereo: 0
>>+ .freq = 87*16000,
>>+ .muted = 1,
>>};
>
> ...
>
> IMHO it is not a good idea to skip default initilised members. IT is self
> documenting to see all members, and it is easier to change them, if
> required. Especially if the old code had it.
I think you are half-right :)
It is personal preference whether or not to list default initialized
members. However -- if the previous code [like the code above]
initialized all its members specifically, then the C99 initializers
cleanup should not change that practice.
Jeff
prev parent reply other threads:[~2002-11-30 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-30 17:45 Art Haas
2002-11-30 21:01 ` Bernd Eckenfels
2002-11-30 21:06 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DE92854.6000000@pobox.com \
--to=jgarzik@pobox.com \
--cc=ecki@calista.eckenfels.6bone.ka-ip.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome