From: Jeff Garzik <jgarzik@pobox.com>
To: David Ashley <dash@xdr.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.18 8139too.c driver fix for mii-tool
Date: Mon, 02 Dec 2002 11:23:50 -0500 [thread overview]
Message-ID: <3DEB8916.6090901@pobox.com> (raw)
In-Reply-To: <200212021611.gB2GBqD00707@xdr.com>
David Ashley wrote:
> mii-tool doesn't work with the 8139too.c driver (RTL8139 based network cards).
> Internally the driver uses phy ID #'s 32+, but when ioctls are used to
> access the phy registers, the ID is masked down to 0-0x1f, so none of them
> work properly, and mii-tool fails.
>
> The fix is to change the masking done in the top of netdev_ioctl:
> if (cmd != SIOCETHTOOL) {
> /* With SIOCETHTOOL, this would corrupt the pointer. */
> data->phy_id &= 0x3f; // was 0x1f (DA) 20021202
> data->reg_num &= 0x1f;
> }
Already fixed in the latest stable kernel, 2.4.20.
But thanks for testing though!
prev parent reply other threads:[~2002-12-02 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-02 16:11 David Ashley
2002-12-02 16:23 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DEB8916.6090901@pobox.com \
--to=jgarzik@pobox.com \
--cc=dash@xdr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome