From: Jeff Garzik <jgarzik@pobox.com>
To: "White, Charles" <Charles.White@hp.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Jens Axboe <axboe@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.20 cciss patch 01 - adds support for the SA641, SA642 and SA6400 controllers.
Date: Wed, 04 Dec 2002 18:03:05 -0500 [thread overview]
Message-ID: <3DEE89A9.2000201@pobox.com> (raw)
In-Reply-To: <A2C35BB97A9A384CA2816D24522A53BB03991726@cceexc18.americas.cpqcorp.net>
White, Charles wrote:
> linux-2.4.20.cciss_p01/drivers/block/cciss.c
> --- linux-2.4.20.orig/drivers/block/cciss.c Thu Nov 28 18:53:12 2002
> +++ linux-2.4.20.cciss_p01/drivers/block/cciss.c Wed Dec 4
> 15:09:39 2002
> @@ -56,6 +56,11 @@
> #include "cciss.h"
> #include <linux/cciss_ioctl.h>
>
> +/* remove when PCI_DEVICE_ID_COMPAQ_CCISSC is in pci_ids.h */
> +#ifndef PCI_DEVICE_ID_COMPAQ_CCISSC
> +#define PCI_DEVICE_ID_COMPAQ_CCISSC 0x46
> +#endif
> +
the patch looks simple and obvious, though I have one objection: as the
comment indicates, this patch hunk should instead be in
include/linux/pci_ids.h. There is no rule against modifying pci_ids.h
-- please do so, and not crap up drivers with tons of these ifdefs...
prev parent reply other threads:[~2002-12-04 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-04 22:23 White, Charles
2002-12-04 22:48 ` Adrian Bunk
2002-12-04 23:03 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DEE89A9.2000201@pobox.com \
--to=jgarzik@pobox.com \
--cc=Charles.White@hp.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome