From: Matthew Dobson <colpatch@us.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Trivial Patch Monkey <trivial@rustcorp.com.au>,
linux-kernel@vger.kernel.org
Subject: [patch] fix broken topology functions
Date: Wed, 04 Dec 2002 15:54:07 -0800 [thread overview]
Message-ID: <3DEE959F.7080600@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
Linus,
The register_(node|memblk)_driver functions are broken. Pat Mochel
recently updated sysfs to make sure that when you register a driver that
it's associated devclass is already registered. The way node/memblk
registration is done now is backwards and causes panic's on NUMA
systems. Please apply this patch to fix it.
Cheers!
-Matt
[-- Attachment #2: topo_ordering-2.5.50.patch --]
[-- Type: text/plain, Size: 1104 bytes --]
diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.50-vanilla/drivers/base/memblk.c linux-2.5.50-topo_ordering/drivers/base/memblk.c
--- linux-2.5.50-vanilla/drivers/base/memblk.c Wed Nov 27 14:36:23 2002
+++ linux-2.5.50-topo_ordering/drivers/base/memblk.c Wed Dec 4 15:50:52 2002
@@ -49,7 +49,7 @@
static int __init register_memblk_type(void)
{
- driver_register(&memblk_driver);
- return devclass_register(&memblk_devclass);
+ devclass_register(&memblk_devclass);
+ return driver_register(&memblk_driver);
}
postcore_initcall(register_memblk_type);
diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.50-vanilla/drivers/base/node.c linux-2.5.50-topo_ordering/drivers/base/node.c
--- linux-2.5.50-vanilla/drivers/base/node.c Wed Nov 27 14:35:50 2002
+++ linux-2.5.50-topo_ordering/drivers/base/node.c Wed Dec 4 15:50:52 2002
@@ -93,7 +93,7 @@
static int __init register_node_type(void)
{
- driver_register(&node_driver);
- return devclass_register(&node_devclass);
+ devclass_register(&node_devclass);
+ return driver_register(&node_driver);
}
postcore_initcall(register_node_type);
next reply other threads:[~2002-12-04 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-04 23:54 Matthew Dobson [this message]
2002-12-05 0:20 ` William Lee Irwin III
2002-12-05 21:35 ` Matthew Dobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DEE959F.7080600@us.ibm.com \
--to=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome