mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: george anzinger <george@mvista.com>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] High-res-timers part 1 (core) take 20
Date: Mon, 09 Dec 2002 22:55:45 -0800	[thread overview]
Message-ID: <3DF58FF1.9C3A5BF3@mvista.com> (raw)
In-Reply-To: <20021209073434.A24382@devserv.devel.redhat.com>

Arjan van de Ven wrote:
> 
> On Mon, Dec 09, 2002 at 04:27:56AM -0800, george anzinger wrote:
> > >
> > > that's why spinlocks are effectively nops on UP.
> > > What you say is true of just about every spinlock user, and no
> > > they shouldn't all do some IF_SMP() thing; the spinlock itself should be
> > > (and is) zero on UP
> >
> > But with preemption, they really are not nops on UP...
> 
> that doesn't justify fuglyfying the kernel code. If you can't live
> with the overhead of preemption, disable preemption. Simple.
> We DON'T want
> spin_lock_nop_on_preempt()
> ...
> 
> spin_unlock_nop_on_preempt()
> 
> really, I don't, and I can't see anyone else wanting that either

Well, I just thought it was an optimization.  I will leave
it the way it is.

-- 
George Anzinger   george@mvista.com
High-res-timers: 
http://sourceforge.net/projects/high-res-timers/
Preemption patch:
http://www.kernel.org/pub/linux/kernel/people/rml

      reply	other threads:[~2002-12-10  6:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-08  7:46 george anzinger
2002-12-08  9:50 ` Arjan van de Ven
2002-12-09  7:03   ` george anzinger
2002-12-09  8:21     ` Robert Love
2002-12-09  8:53     ` Arjan van de Ven
2002-12-09 12:27       ` george anzinger
2002-12-09 12:34         ` Arjan van de Ven
2002-12-10  6:55           ` george anzinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DF58FF1.9C3A5BF3@mvista.com \
    --to=george@mvista.com \
    --cc=arjanv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome