From: Andrew Morton <akpm@digeo.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: move LOG_BUF_SIZE to header file
Date: Tue, 10 Dec 2002 11:41:29 -0800 [thread overview]
Message-ID: <3DF64369.81F288FE@digeo.com> (raw)
In-Reply-To: <Pine.LNX.4.33L2.0212101108550.12283-100000@dragon.pdx.osdl.net>
"Randy.Dunlap" wrote:
>
> Hi,
>
> I'd like to see LOG_BUF_LEN from kernel/printk.c moved to a header file
> so that some non-kernel (kernel-mode) tools can know the value being
> used (tools like kmsgdump or lkcd etc.).
>
> This patch moves LOG_BUF_LEN to include/linux/kernel.h .
> Or it could go to a separate (new) header file...
>
> ...
> -#if defined(CONFIG_X86_NUMAQ) || defined(CONFIG_IA64)
> -#define LOG_BUF_LEN (65536)
> -#elif defined(CONFIG_ARCH_S390)
> -#define LOG_BUF_LEN (131072)
> -#elif defined(CONFIG_SMP)
> -#define LOG_BUF_LEN (32768)
> -#else
> -#define LOG_BUF_LEN (16384) /* This must be a power of two */
> -#endif
> -
> -#define LOG_BUF_MASK (LOG_BUF_LEN-1)
It's probably better to move all this gunk into the config
system. Then your app can use CONFIG_LOG_BUF_LEN, too.
next prev parent reply other threads:[~2002-12-10 19:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-10 19:16 Randy.Dunlap
2002-12-10 19:41 ` Andrew Morton [this message]
2002-12-17 6:11 ` [PATCH] " Randy.Dunlap
2002-12-17 6:39 ` James H. Cloos Jr.
2002-12-17 17:22 ` Randy.Dunlap
2002-12-17 9:41 ` Christoph Hellwig
2002-12-17 17:14 ` Randy.Dunlap
2002-12-17 17:27 ` Andrew Morton
2002-12-17 22:33 ` [PATCH] (v3) move LOG_BUF_SIZE to header/config Randy.Dunlap
2002-12-18 1:14 ` Andrew Morton
2002-12-18 4:03 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DF64369.81F288FE@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome