From: Eyal Lebedinsky <eyal@eyal.emu.id.au>
To: Rik van Riel <riel@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.20-rmap15b - compile failure
Date: Fri, 13 Dec 2002 21:55:38 +1100 [thread overview]
Message-ID: <3DF9BCAA.C96AA165@eyal.emu.id.au> (raw)
In-Reply-To: <Pine.LNX.4.50L.0212122349520.17748-100000@imladris.surriel.com>
I had a failure building NVIDIA_kernel/nv.c (the nvidia driver):
http://download.nvidia.com/XFree86_40/1.0-4191/NVIDIA_kernel-1.0-4191.tar.gz
It uses
pte = *pte_offset(pg_mid_dir, address);
but this patch removes pte_offset().
1) what is the correct fix (use pte_offset_kernel?)?
2) in general, is it wise to remove pte_offset() or should it
be left for compatability?
I should clearly say that I am not familiar with the workings of this
patch, but find that it is likely to break drivers that are not in
the kernel tree (assuming you patch them).
--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
next prev parent reply other threads:[~2002-12-13 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-13 1:51 [PATCH] 2.4.20-rmap15b Rik van Riel
2002-12-13 9:25 ` Eyal Lebedinsky
2002-12-13 10:55 ` Eyal Lebedinsky [this message]
2002-12-13 11:30 ` [PATCH] 2.4.20-rmap15b - compile failure Rik van Riel
[not found] ` <200212161610.gBGGAuB7028719@localhost.localdomain>
2002-12-17 21:50 ` [PATCH] 2.4.20-rmap15b Rik van Riel
2002-12-17 21:54 ` Georg Nikodym
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DF9BCAA.C96AA165@eyal.emu.id.au \
--to=eyal@eyal.emu.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®