From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
manfred@colorfullife.com
Subject: Re: [PATCH] sys_poll SuS compliance fix
Date: Wed, 18 Dec 2002 12:06:11 -0500 [thread overview]
Message-ID: <3E00AB03.8010808@pobox.com> (raw)
In-Reply-To: <200212181631.gBIGVLJ11794@hera.kernel.org>
Linux Kernel Mailing List wrote:
> ChangeSet 1.942, 2002/12/18 10:33:48-02:00, manfred@colorfullife.com
>
> [PATCH] sys_poll SuS compliance fix
> diff -Nru a/fs/select.c b/fs/select.c
> --- a/fs/select.c Wed Dec 18 08:31:22 2002
> +++ b/fs/select.c Wed Dec 18 08:31:22 2002
> @@ -417,7 +417,7 @@
> int nchunks, nleft;
>
> /* Do a sanity check on nfds ... */
> - if (nfds > NR_OPEN)
> + if (nfds > current->files->max_fdset && nfds > OPEN_MAX)
> return -EINVAL;
The changeset description is awful, can you give us more details
Manfred? [also in the future can you please give Linus more description
with your patches?]
In particular, I wonder if "||" is more appropriate than "&&"?
Jeff
parent reply other threads:[~2002-12-18 16:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200212181631.gBIGVLJ11794@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E00AB03.8010808@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome