From: John Reiser <jreiser@BitWagon.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: AnonimoVeneziano <voloterreno@tin.it>,
Patrick Petermair <black666@inode.at>,
Roland Quast <rquast@hotshed.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: vt8235 fix, hopefully last variant
Date: Sat, 21 Dec 2002 09:57:42 -0800 [thread overview]
Message-ID: <3E04AB96.5030408@BitWagon.com> (raw)
In-Reply-To: <20021219112640.A21164@ucw.cz>
Looking at the important piece:
-----
> + /* Always use 4 address setup clocks on ATAPI devices */
> + if (drive->media != ide_disk)
> + t.setup = 4;
-----
it seems to me that using 4 for t.setup also should be done unless _all_ devices
on that cable are ide_disk. In particular, if one device is ide_disk but the
other is not, then "t.setup = 4;" should be used even when talking to the ide_disk.
Otherwise the non-ide_disk device might get confused, respond when it should not,
and garble the transaction. Or, is such a bad thing prevented in some other way?
--
John Reiser, jreiser@BitWagon.com
next prev parent reply other threads:[~2002-12-21 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-19 10:26 Vojtech Pavlik
2002-12-19 13:34 ` AnonimoVeneziano
2002-12-19 17:41 ` John Reiser
2002-12-20 20:12 ` Patrick Petermair
2002-12-21 9:21 ` Vojtech Pavlik
2002-12-21 10:51 ` Patrick Petermair
2002-12-21 12:00 ` Vojtech Pavlik
2002-12-21 0:25 ` Christian Seidemann
2002-12-23 19:30 ` AnonimoVeneziano
2002-12-23 21:42 ` Patrick Petermair
2002-12-24 0:09 ` AnonimoVeneziano
2002-12-24 0:26 ` Patrick Petermair
2002-12-24 0:33 ` AnonimoVeneziano
2002-12-21 17:57 ` John Reiser [this message]
2002-12-21 18:27 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E04AB96.5030408@BitWagon.com \
--to=jreiser@bitwagon.com \
--cc=black666@inode.at \
--cc=linux-kernel@vger.kernel.org \
--cc=rquast@hotshed.com \
--cc=vojtech@suse.cz \
--cc=voloterreno@tin.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome