From: Manfred Spraul <manfred@colorfullife.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] M68k net local_irq*() updates
Date: Fri, 27 Dec 2002 21:27:55 +0100 [thread overview]
Message-ID: <3E0CB7CB.2030800@colorfullife.com> (raw)
>
>
>
> skblen = skb->len;
>
>- save_flags(flags);
>- cli();
>+ local_irq_save(flags);
>
>
This would be the wrong thing (tm) for SMP: cli() gives a compile error
for SMP, local_irq_save() creates the impression that the driver works
on SMP systems. m68k is UP only, thus there is no need to fix it properly.
What about adding
+ #ifdef CONFIG_SMP
+ #error This driver does not work on SMP
+ #endif
Or a Kconfig dependency on !CONFIG_SMP?
--
Manfred
next reply other threads:[~2002-12-27 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-27 20:27 Manfred Spraul [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-27 16:11 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E0CB7CB.2030800@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome