Paul Gortmaker wrote:

>I've a couple of quick comments after looking over the patch:
>
>  
>
>>-"Last modified Nov 1, 2000 by Paul Gortmaker\n";
>>+"Last modified January 20, 2003 by Jeff Muizelaar\n";
>>    
>>
>
>Feel free to delete this "Last modified" stuff altogether.
>It is just extra verbage at boot we don't need. (Blame 
>Jeff Garzik -- he put it there, not me...   ;-)
>
It's gone with the attached patch. I also changed the version string a 
bit. I figure enough of the driver has changed in the last 9 years to 
warrant a small increment.

>  
>
>>+               free_irq(dev->irq, dev);
>>+               release_region(dev->base_addr, NE_IO_EXTENT);
>>+               unregister_netdev(dev);
>>+               kfree(dev->priv);
>>+               kfree(dev);
>>    
>>
>
>It is usually good practice to unregister a device as the 
>first thing, and then release its associated resources once
>you know the kernel doesn't hold any references to it.
>  
>
Agreed. I also fixed the legacy cleanup code to do things this way, and 
removed some old pnp code I had forgotten about.
It would probably be good to unify both sets of init/cleanup code but I 
want to keep the changes small for now.

Adam have you made any progress on supporting non-PnP legacy devices yet?

-Jeff