Martin J. Bligh wrote: >>Personally, I feel statements like these are prone to continual error >>and confusion. I would prefer to break each test like this out into >>separate assignment and test statements. Combining them decreases >>readability, while saving a paltry few extra bytes of source code. >> >>Sure, the gcc warning is silly, but the code is a bit obtuse too. > > > True, I agree with this in general, and I think Andrew does too, from > previous comments. I was just being lazy ;-) More appropriate patch below. > Compile tested, but not run. > > M. Ok... drivers/base/cpu.c had the double parens, unlike memblkc. & node.c This patch will make them all more readable and consistent... Down with warnings!! We must liberate them, and set them free! ;) -Matt