From: Manfred Spraul <manfred@colorfullife.com>
To: Neil Moore <neil@s-z.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Unix code in Linux
Date: Fri, 20 Jun 2003 15:30:01 +0200 [thread overview]
Message-ID: <3EF30C59.1070206@colorfullife.com> (raw)
Neil wrote:
>Is there any reason to replace this
>code?
>
Yes, it's ugly as hell.
As far as I can see, the only user of ate_malloc are a few rmalloc
calls. There is one rmalloc_align call, but afaics the function is not
implemented.
The code is filled with #defines that rename linux functions -
mutex_spinlock, spin_lock_destroy(), whatever.
There is so much renaming that they even create a prototype for a #define:
> arch/ia64/sn/io/sn1/pcibr.c
> L40: #define rmalloc atealloc
> L331: extern uint64_t rmalloc(struct map *mp, size_t size);
(it seems sn1 got killed recently, I searched in lxr.linux.no)
AFAICS ate_malloc should die, and the rmalloc callers should use
request_resource & friends from <linux/ioport.h>.
--
Manfred
next reply other threads:[~2003-06-20 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-20 13:30 Manfred Spraul [this message]
2003-06-21 8:29 ` Manfred Spraul
-- strict thread matches above, loose matches on Subject: below --
2003-06-19 22:43 Neil Moore
2003-06-19 23:13 ` Miquel van Smoorenburg
2003-06-20 1:13 ` Neil Moore
2003-06-20 12:27 ` Jesse Pollard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EF30C59.1070206@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@s-z.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®