From: Manfred Spraul <manfred@colorfullife.com>
To: Vinay K Nallamothu <vinay-rc@naturesoft.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.0-test4][NET] ni5010.c: remove cli/sti
Date: Sun, 24 Aug 2003 18:31:44 +0200 [thread overview]
Message-ID: <3F48E870.2070205@colorfullife.com> (raw)
Vinay wrote:
>drivers/net/ni5010.c:
>This patch replaces cli/sti with spinlocks. Compiles fine though
>untested.
>
>
I don't have the hardware either, but the patch seems to be wrong:
The cli() call was in hardware_send_packet(). I assume that this
function should be synchronized against concurrent interrupts - both
functions access the hardware. Due to the dev_xmit_lock, the networking
core already guarantees that hardware_send_packet is never reentered.
cli() provided protection against concurrent interrupts on other cpus,
spin_lock_irqsave() doesn't.
Could you add a spin_lock()/spin_unlock() into ni5010_interrupt?
--
Manfred
next reply other threads:[~2003-08-24 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-24 16:31 Manfred Spraul [this message]
2003-08-25 11:31 ` Vinay K Nallamothu
-- strict thread matches above, loose matches on Subject: below --
2003-08-24 15:07 Vinay K Nallamothu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F48E870.2070205@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinay-rc@naturesoft.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome