Adrian Bunk wrote: > It seems gcc is right, there are two .get_link members in this struct: > > > <-- snip --> > > ... > static struct ethtool_ops gem_ethtool_ops = { David, would you look over this patch and apply/modify? I would prefer to use the generic ethtool_op_get_link, because (a) sungem is already using netif_carrier_xxx, and (b) if ->get_link ever returns an incorrect value, that signals a netif_carrier_xxx bug exists. As a tangent, gem_pcs_interrupt appears to call netif_carrier_xxx but not set gem->lstate. David/Ben, is that a bug? Thanks, Jeff