From: "Kevin P. Fleming" <kpfleming@backtobasicsmgmt.com>
To: Sam Ravnborg <sam@ravnborg.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] make O=foo does not fail if foo does not exist
Date: Sun, 28 Sep 2003 14:51:28 -0700 [thread overview]
Message-ID: <3F7757E0.7030906@backtobasicsmgmt.com> (raw)
Simple enough... I mistyped the path to the object directory, and the
build continued in the source directory anyway. This patch causes the
build to stop, although with a non-obvious error message. A better fix
would actually check KBUILD_OUTPUT after the cd && pwd test, but I'll
leave that to you if you're so inclined.
--- linux-2.6/Makefile~ Sat Sep 27 19:26:01 2003
+++ linux-2.6/Makefile Sun Sep 28 14:46:05 2003
@@ -81,7 +81,7 @@
ifneq ($(KBUILD_OUTPUT),)
# Invoke a second make in the output directory, passing relevant
variables
- KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT); /bin/pwd)
+ KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd)
.PHONY: $(MAKECMDGOALS) all
reply other threads:[~2003-09-28 21:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F7757E0.7030906@backtobasicsmgmt.com \
--to=kpfleming@backtobasicsmgmt.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®