Re: 2.4.23pre6aa2 - some problems [with patches]

[Eyal Lebedinsky <eyal@eyal.emu.id.au>]

Andrea Arcangeli wrote:
> 
> On Sun, Oct 05, 2003 at 01:38:20AM +1000, Eyal Lebedinsky wrote:
> > This is most unusual as -aa patches usually apply clean, but I am
> > encountering a number of build problems.
> 
> > And building i2c-2.7.0 (which I need for sensors) is failing.
> >
> > depmod: *** Unresolved symbols in
> > /lib/modules/2.4.23-pre6-aa2/kernel/drivers/ie
> > ee1394/pcilynx.o
> > depmod:         i2c_bit_add_bus_Rca543f36
> > depmod:         i2c_transfer_R1dea91d1
> > depmod:         i2c_bit_del_bus_Rdf920b11
> > depmod: *** Unresolved symbols in
[trimmed]
> 
> this looks like if you didn't compile the needed i2c (or maybe it was
> due the lack of a `make dep` first), the above modules (pcilynx bttv
> msp3400) looks innocent.

OK, carefully inspecting the logs explains the above. -aa2 breaks the
build
of i2c-2.7.0, but my script already removed the original i2c modules by
then. The failure is just another static HZ initializer situation.

I think that we need an option to revert HZ to a constant for people
that do not want to fight with this change for now (I am sure there
are other drivers in the wild that will take a while to catch up
with this change even after it makes mainline).

gcc -I/usr/src/linux/include -O2 -DLM_SENSORS -D__KERNEL__ -DMODULE
-fomit-frame
-pointer -DEXPORT_SYMTAB -DMODVERSIONS -include
/usr/src/linux/include/linux/mod
versions.h -c kernel/i2c-philips-par.c -o kernel/i2c-philips-par.o
kernel/i2c-philips-par.c:163: initializer element is not constant
kernel/i2c-philips-par.c:163: (near initialization for
`bit_lp_data.timeout')
kernel/i2c-philips-par.c:172: initializer element is not constant
kernel/i2c-philips-par.c:172: (near initialization for
`bit_lp_data2.timeout')

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>