From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>,
Marcelo Tosatti <marcelo.tosatti@cyclades.com.br>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] BUG() in exec_mmap()
Date: Thu, 09 Oct 2003 23:43:33 +0300 [thread overview]
Message-ID: <3F85C875.2030506@kolumbus.fi> (raw)
In-Reply-To: <Pine.LNX.4.44.0310091718080.3040-100000@logos.cnet>
Marcelo Tosatti wrote:
>On Thu, 9 Oct 2003, Dave Kleikamp wrote:
>
>
>
>>Marcelo,
>>A recent change to exec_mmap() removed the initialization of old_mm,
>>leaving an uninitialized use of it. This patch would completely remove
>>old_mm from the function. Is this what was intended?
>>
>>
>
>Yes.
>
>Blame me... patch applied, thank you!
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
Hmm.. you still need to mmput(old_mm) etc, just remove the mm_users == 1
optimization from the beginning of exec_mmap, so this patch is wrong!
--Mika
next prev parent reply other threads:[~2003-10-09 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 20:10 Dave Kleikamp
2003-10-09 20:19 ` Marcelo Tosatti
2003-10-09 20:25 ` 2.4.x performance tests " Marcelo Tosatti
2003-10-09 20:43 ` Mika Penttilä [this message]
2003-10-09 20:47 ` Marcelo Tosatti
2003-10-10 1:01 Ernie Petrides
2003-10-10 10:57 ` Marcelo Tosatti
2003-10-10 1:24 Ernie Petrides
2003-10-10 11:18 Ernie Petrides
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F85C875.2030506@kolumbus.fi \
--to=mika.penttila@kolumbus.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=marcelo.tosatti@cyclades.com.br \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®