Ingo Oeser wrote: > On Wednesday 15 October 2003 01:12, Mike Waychison wrote: > >>The problem still remains in 2.6 that we limit the count to 256. I've >>attached a quick patch that I've compiled and tested. I don't know if >>there is a better way to handle dynamic assignment of minors (haven't >>kept up to date in that realm), but if there is, then we should probably >> use it instead. > > > > In your patch you allocate inside the spinlock. > > I would suggest to do sth. like the following: > Better yet.. we could move it into an __init section that will panic if the allocation fails (this should be the desired behaviour..). This way we don't even have to grab the lock either. Mike Waychison