From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F593C433FE for ; Thu, 24 Mar 2022 12:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349945AbiCXMMA (ORCPT ); Thu, 24 Mar 2022 08:12:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbiCXML6 (ORCPT ); Thu, 24 Mar 2022 08:11:58 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676FBA8884; Thu, 24 Mar 2022 05:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1648123824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ncLgYxkYoQriXSXIVKrIBujezisB1bmyL200+xh6duc=; b=M8gBb5/GBMzGIK98oxRzs+ggFRKhZy5iFMXJNqb01wjMke/kBfvB6s2NaeqElnLVIU+3+k RuHKHlDrprC+JXj0gZgoAKmalC4SAAmQZa+uPUIcT8z+zOaAaLncdk30eHwLZpnACbA8nx nkrVoBu8uFd89iGgbMNv5GXI8tnZVu8= Date: Thu, 24 Mar 2022 12:10:15 +0000 From: Paul Cercueil Subject: Re: [PATCH] pinctrl: Ingenic: Add missing UART2 group C for X1000/E To: Yunian Yang Cc: linux-mips@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <3H099R.GNKMFWXCJG5U1@crapouillou.net> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yunian, Le jeu., mars 24 2022 at 20:04:41 +0800, Yunian Yang=20 a =E9crit : > X1000/E has a third UART2 pin group selection, which uses the TDI(G2)=20 > as RX > and TDO(G1) as TX. This configuration is becoming increasingly=20 > popular in > newer core boards, such as the Halley2 v4.1. This is done by enabling > function 1 of a "virtual pin" PC31. See section 19.3.3 of the X1000 > Programming Manual for details. >=20 > Signed-off-by: Yunian Yang > --- > drivers/pinctrl/pinctrl-ingenic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/pinctrl/pinctrl-ingenic.c=20 > b/drivers/pinctrl/pinctrl-ingenic.c > index 2712f51eb238..29709059d62b 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -1982,6 +1982,7 @@ static int x1000_uart1_data_a_pins[] =3D { 0x04,=20 > 0x05, }; > static int x1000_uart1_data_d_pins[] =3D { 0x62, 0x63, }; > static int x1000_uart1_hwflow_pins[] =3D { 0x64, 0x65, }; > static int x1000_uart2_data_a_pins[] =3D { 0x02, 0x03, }; > +static int x1000_uart2_data_c_pins[] =3D { 0x5f, 0x5f, }; One should be enough. Looks fine otherwise. Cheers, -Paul > static int x1000_uart2_data_d_pins[] =3D { 0x65, 0x64, }; > static int x1000_sfc_data_pins[] =3D { 0x1d, 0x1c, 0x1e, 0x1f, }; > static int x1000_sfc_clk_pins[] =3D { 0x1a, }; > @@ -2058,6 +2059,7 @@ static const struct group_desc x1000_groups[] =3D=20 > { > INGENIC_PIN_GROUP("uart1-data-d", x1000_uart1_data_d, 1), > INGENIC_PIN_GROUP("uart1-hwflow", x1000_uart1_hwflow, 1), > INGENIC_PIN_GROUP("uart2-data-a", x1000_uart2_data_a, 2), > + INGENIC_PIN_GROUP("uart2-data-c", x1000_uart2_data_c, 1), > INGENIC_PIN_GROUP("uart2-data-d", x1000_uart2_data_d, 0), > INGENIC_PIN_GROUP("sfc-data", x1000_sfc_data, 1), > INGENIC_PIN_GROUP("sfc-clk", x1000_sfc_clk, 1), > @@ -2115,7 +2117,7 @@ static const char *x1000_uart0_groups[] =3D {=20 > "uart0-data", "uart0-hwflow", }; > static const char *x1000_uart1_groups[] =3D { > "uart1-data-a", "uart1-data-d", "uart1-hwflow", > }; > -static const char *x1000_uart2_groups[] =3D { "uart2-data-a",=20 > "uart2-data-d", }; > +static const char *x1000_uart2_groups[] =3D { "uart2-data-a",=20 > "uart2-data-c", "uart2-data-d", }; > static const char *x1000_sfc_groups[] =3D { "sfc-data", "sfc-clk",=20 > "sfc-ce", }; > static const char *x1000_ssi_groups[] =3D { > "ssi-dt-a-22", "ssi-dt-a-29", "ssi-dt-d", > -- > 2.30.2