From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934469AbcIPLmw (ORCPT ); Fri, 16 Sep 2016 07:42:52 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:48307 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757736AbcIPLmt (ORCPT ); Fri, 16 Sep 2016 07:42:49 -0400 X-AuditID: cbfec7f2-f79556d000002c42-cc-57dbdab48550 Subject: Re: [PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values used for configuration To: Linus Walleij Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Rob Herring , Mark Rutland , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , "devicetree@vger.kernel.org" , Kukjin Kim , Arnd Bergmann , Javier Martinez Canillas , Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <3a004c08-26b3-d5cd-dbc3-bc0f47814570@samsung.com> Date: Fri, 16 Sep 2016 13:42:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHe3bv3a6j1eO0PNqLNepDUZYt6pIVRS/cDxG9EIsg6qI3FZ3K rkr2RSUy02ilvTEqRZzWXG/bmNl6kalzaLXEsnQqlqSWaZAampq5XQW//c5z/uf8+R8emlC+ ocLo+KRUXpfEJaqkctLuGvOst7V5NRstj9TMZIFLxjy9/ZhiimrfUczPAbOE6e+LZPTd/QTj 8TyRMdcnyiWMpbuFYpqf35Eytz2vJIzxU5OEufCyVsbU/LxIMabnE2jXQtZ8z4zY8b8FiK0y dMhYi+mSlG1veSFlraWZrE0//XTFZkLskGX5oYAT8u0xfGJ8Oq/bsPO0PO7a1QkqpVV+dtxl kmUhPZ2HAmjAmyH3Y6dM5MXwvvOxNA/JaSU2ImiqKqHEYghBy61+NDvhqnYQPlbiMgTGihBR 1IPghrdS4msE4TNQ4mqU+jgYr4N8+5h/E4HHSSiqvO/3k2I1WMtL/SIF3gnZbi/lYxKvhvOv 3NMaml6Ej4OjgxclgTBa2En6OAAfhbpJq19O4DXQN1xAihwOVvMA4fMCnE1DVuFX/x7Ay8BS TYgB9kKHqVUichD8qLfNxF8KzYX5pDirR+By9knEogLBTfsdqaiKgpr6phnnBVBgv0WIBgrI zVGKEhYGextmDHbDaJWHEC/0FcGXEZvsKgo3zAlkmBPCMCdEMSJMKJhPE7SxvKCOEDitkJYU GxGdrLWg6T/W+K/+9zM04t7mRJhGqvmK+3fbNEqKSxcytE4ENKEKVhz77NUoFTFcxjlel3xK l5bIC060hCZVIYoXxR80ShzLpfIJPJ/C62a7EjogLAupGXLln02Zq/ZP7Qj5dm1fp2Wh46D8 Q+xwUN0B+zC2rdmbrulNNV7O6KK4w6+t3Q+HNje+LSl7MJBj13+iA087ayoTBjNG5SF1bXp2 RVjonvxnUe7jCyq2bpk3Gry/x5Nn/I67grSBrSOhjqno6w2K1bnJ1eZf6m/F7UcOxJ0sr1GR QhwXuZbQCdx/ztxIUV8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsVy+t/xq7ott26HG3yZbGnxd9IxdouNM9az Wsw/co7V4s3bNUwWr18YWvQ/fs1scf78BnaLKX+WM1lsenyN1eLyrjlsFjPO72OyWHr9IpNF 694j7BaH37SzWqza9YfRgd9jzbw1jB6/f01i9Ng56y67x6ZVnWwed67tYfPYvKTeY0s/UKhv yypGj8+b5AI4o9xsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qB PCMDNODgHOAerKRvl+CWMXHCH9aCm1wVv4+tYm9g7OfoYuTkkBAwkTh2YDczhC0mceHeerYu Ri4OIYEljBJfug4zQzjPGCWa3l1hB6kSFkiTuPb5GCOILSKgI9G97ScrRFEfo8S3p7/BHGaB 3ywSJ3ZsA5vLJmAssXn5EjYQm1fATqLxxG1WEJtFQFWied8JsKmiAhESt1Z9ZISoEZT4Mfke C4jNKRAs8WhJD1ANB9BQdYkpU3JBwswC8hKb17xlnsAoMAtJxyyEqllIqhYwMq9iFEktLc5N zy020itOzC0uzUvXS87P3cQIjOhtx35u2cHY9S74EKMAB6MSD++KubfChVgTy4orcw8xSnAw K4nwht64HS7Em5JYWZValB9fVJqTWnyI0RTohYnMUqLJ+cBkk1cSb2hiaG5paGRsYWFuZKQk zjv1w5VwIYH0xJLU7NTUgtQimD4mDk6pBkaf3efPayzecijvYm1itsJVxtVy9cum7rh7/o18 zL2pzW22P/vstP7o2xj+E359bk10+9QdRatOa63O2vR9v9bM/Ejue7kro++f7Gv833d44s7Q 3oKJS1+mnap7Hrh0DsPiX6uumbvzpNcGlCTODOBz/R7pIccUWLZwWoxFv1NP+wbTuMKT3guV WIozEg21mIuKEwHYaVSa/gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160916114244eucas1p2f585ef754b0523022a04a5646a06da36 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?7YGs7Ims7Iuc7Yag7ZSEG1NSUE9MLUtlcm5lbCAoVFApGw==?= =?UTF-8?B?7IK87ISx7KCE7J6QGy4vU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?S3J6eXN6dG9mIEtvemxvd3NraRtTUlBPTC1LZXJuZWwgKFRQ?= =?UTF-8?B?KRtTYW1zdW5nIEVsZWN0cm9uaWNzGy4vU2VuaW9yIFNvZnR3YXJlIEVuZ2lu?= =?UTF-8?B?ZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160916114244eucas1p2f585ef754b0523022a04a5646a06da36 X-RootMTR: 20160916114244eucas1p2f585ef754b0523022a04a5646a06da36 References: <1472714638-15676-1-git-send-email-k.kozlowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2016 10:20 PM, Linus Walleij wrote: > I have one comment though, if you're anyway making changes to all > the DTS files: > > On Thu, Sep 1, 2016 at 9:23 AM, Krzysztof Kozlowski > wrote: > >> - samsung,pin-function = <2>; >> - samsung,pin-pud = <0>; >> - samsung,pin-drv = <0>; >> + samsung,pin-function = ; >> + samsung,pin-pud = ; >> + samsung,pin-drv = ; > > Nowadays we have standard bindings for this, see > Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > Section "Generic pin multiplexing node content". > > By patching the driver and bindings to accept also the standard > bindings with just function and pins and also adding support > for standard pin configurations like bias-disable > bias-pull-up with the old samsung,* bindings as a fallback > etc you can actually modernize the whole binding and > DTS looks to something simpler. > > You will find that this is how newer platforms do it. > > But it is admittedly a bigger project. Indeed it would be nice to support generic bindings. Almost certainly I won't have time for implementing this but it looks like a good task for newcomers. Best regards, Krzysztof