From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5CA4C433ED for ; Fri, 30 Apr 2021 11:36:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBE4961077 for ; Fri, 30 Apr 2021 11:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231861AbhD3Lhb (ORCPT ); Fri, 30 Apr 2021 07:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbhD3Lh3 (ORCPT ); Fri, 30 Apr 2021 07:37:29 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 366AFC06174A; Fri, 30 Apr 2021 04:36:41 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lcRRg-0023WH-DF; Fri, 30 Apr 2021 13:36:32 +0200 Message-ID: <3a0671bd6a9650fdcdf5cb8414526f6204518774.camel@sipsolutions.net> Subject: Re: [PATCH] mac80211: Remove redundant assignment to ret From: Johannes Berg To: Yang Li Cc: davem@davemloft.net, kuba@kernel.org, nathan@kernel.org, ndesaulniers@google.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Date: Fri, 30 Apr 2021 13:36:31 +0200 In-Reply-To: <1619774483-116805-1-git-send-email-yang.lee@linux.alibaba.com> References: <1619774483-116805-1-git-send-email-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-04-30 at 17:21 +0800, Yang Li wrote: > Variable 'ret' is set to -ENODEV but this value is never read as it > is overwritten with a new value later on, hence it is a redundant > assignment and can be removed. > > Clean up the following clang-analyzer warning: > > net/mac80211/debugfs_netdev.c:60:2: warning: Value stored to 'ret' is > never read [clang-analyzer-deadcode.DeadStores] Can you just turn that warning off? It's really quite pointless to churn the tree for effectively nothing. johannes