From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B78C433F5 for ; Fri, 15 Oct 2021 15:45:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61AD060FF2 for ; Fri, 15 Oct 2021 15:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241010AbhJOPrK (ORCPT ); Fri, 15 Oct 2021 11:47:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241000AbhJOPrJ (ORCPT ); Fri, 15 Oct 2021 11:47:09 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B68EBC061570 for ; Fri, 15 Oct 2021 08:45:02 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id h196so8260252iof.2 for ; Fri, 15 Oct 2021 08:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tsavfGnFECXuxpubCpirg1R3vZvOUaYaxqi9oyOqKwo=; b=ChuHOHn0/F6tN80qDqx9dphmlweCzg+OUkJILwXpV4FyCUsmzM00TVEQEtEJS0/OfH 75MS+LsCPDS7lS0bjpnJTrsuKJne4+iEN9CAiHQ2SZMpSZrKBHaQ5J/5Bj6vzm1DSr4x bK0R94yakoD0MlswRcVe6G7eycVzh7nKTfjwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tsavfGnFECXuxpubCpirg1R3vZvOUaYaxqi9oyOqKwo=; b=0iOSWZtloNizv35ibImKf2hi/LWhIarQWb/41DLtzce+0UPfy71x5G6ld7yEGB6G86 GvGMBVa8MXdgXPUC65gt7amH6oYaextweQO5svLwzvZDW6HLwh7WVcDENZE/safBkOjY rzMFurxGH5CpoTPR73dPpQOoOQ797hTV23rhINfBG3DbKZ0MR48YSng5HW6LEDShdmhN TLy91HjaXhaiEjlkFxhJ7jSooJqdectnk2x78mZklfLuWAXSi32z8w0JhTkHGcqmU9rx RU9bqCQU8Teu67MWmy/wPtw6rxuxk3DiCsYbCO5y3+K4cSnaRI1qFguM7ivs82YWSFdk iPoA== X-Gm-Message-State: AOAM531izrFzDM1gdETqK19Pzqb/wgj0ipoB5mO2WxWdaHAOxEU944kZ ino2PzOrMYlGviZCFY2eeGFe/w== X-Google-Smtp-Source: ABdhPJzdiLVhltf+etzX2lpHjoHWVtxfWghpmqDVlhoBkxCySer4V5YZdZfhfpCYJ8FCX6cCCia1cg== X-Received: by 2002:a05:6602:15cc:: with SMTP id f12mr4251184iow.33.1634312702114; Fri, 15 Oct 2021 08:45:02 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id q17sm2595902iot.16.2021.10.15.08.45.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 08:45:01 -0700 (PDT) Subject: Re: selftests/vm madv_populate.c test To: David Hildenbrand Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <0a20f6b6-5985-8b3e-a577-7495dcf7d2b8@redhat.com> From: Shuah Khan Message-ID: <3a06d58e-7301-6fbc-a305-d9f7c7220843@linuxfoundation.org> Date: Fri, 15 Oct 2021 09:45:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <0a20f6b6-5985-8b3e-a577-7495dcf7d2b8@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/18/21 1:41 AM, David Hildenbrand wrote: > On 18.09.21 00:45, Shuah Khan wrote: >> Hi David, >> >> I am running into the following warning when try to build this test: >> >> madv_populate.c:334:2: warning: #warning "missing MADV_POPULATE_READ or MADV_POPULATE_WRITE definition" [-Wcpp] >>     334 | #warning "missing MADV_POPULATE_READ or MADV_POPULATE_WRITE definition" >>         |  ^~~~~~~ >> >> >> I see that the following handling is in place. However there is no >> other information to explain why the check is necessary. >> >> #if defined(MADV_POPULATE_READ) && defined(MADV_POPULATE_WRITE) >> >> #else /* defined(MADV_POPULATE_READ) && defined(MADV_POPULATE_WRITE) */ >> >> #warning "missing MADV_POPULATE_READ or MADV_POPULATE_WRITE definition" >> >> I do see these defined in: >> >> include/uapi/asm-generic/mman-common.h:#define MADV_POPULATE_READ       22 >> include/uapi/asm-generic/mman-common.h:#define MADV_POPULATE_WRITE      23 >> >> Is this the case of missing include from madv_populate.c? > > Hi Shuan, > > note that we're including "#include ", which in my > understanding maps to the version installed on your system instead > of the one in our build environment.ing. > > So as soon as you have a proper kernel + the proper headers installed > and try to build, it would pick up MADV_POPULATE_READ and > MADV_POPULATE_WRITE from the updated headers. That makes sense: you > annot run any MADV_POPULATE_READ/MADV_POPULATE_WRITE tests on a kernel > that doesn't support it. > > See vm/userfaultfd.c where we do something similar. > Kselftest is for testing the kernel with kernel headers. That is the reason why there is the dependency on header install. > > As soon as we have a proper environment, it seems to work just fine: > > Linux vm-0 5.15.0-0.rc1.20210915git3ca706c189db.13.fc36.x86_64 #1 SMP Thu Sep 16 11:32:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux > [root@vm-0 linux]# cat /etc/redhat-release > Fedora release 36 (Rawhide) This is a distro release. We don't want to have dependency on headers from the distro to run selftests. Hope this makes sense. I still see this on my test system running Linux 5.15-rc5. Can we make this work with kernel headers? thanks, -- Shuah