mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 0/2] perf report: Support annotation of code without symbols
Date: Thu, 20 Feb 2020 21:50:42 +0800	[thread overview]
Message-ID: <3a0a66ad-e266-b37d-d7ec-e194f2191c2d@linux.intel.com> (raw)
In-Reply-To: <20200220120655.GA586895@krava>



On 2/20/2020 8:06 PM, Jiri Olsa wrote:
> On Thu, Feb 20, 2020 at 08:03:18PM +0800, Jin, Yao wrote:
>>
>>
>> On 2/20/2020 7:56 PM, Jiri Olsa wrote:
>>> On Thu, Feb 20, 2020 at 08:59:00AM +0800, Jin Yao wrote:
>>>> For perf report on stripped binaries it is currently impossible to do
>>>> annotation. The annotation state is all tied to symbols, but there are
>>>> either no symbols, or symbols are not covering all the code.
>>>>
>>>> We should support the annotation functionality even without symbols.
>>>>
>>>> The first patch uses al_addr to print because it's easy to dump
>>>> the instructions from this address in binary for branch mode.
>>>>
>>>> The second patch supports the annotation on stripped binary.
>>>>
>>>> Jin Yao (2):
>>>>     perf util: Print al_addr when symbol is not found
>>>>     perf annotate: Support interactive annotation of code without symbols
>>>
>>> looks good, but I'm getting crash when annotating unresolved kernel address:
>>>
>>> jirka
>>>
>>>
>>
>> Thanks for reporting the issue.
>>
>> I guess you are trying the "0xffffffff81c00ae7", let me try to reproduce
>> this issue.
> 
> yes, I also checked and it did not happen before
> 
> jirka
> 


I can reproduce it now.

perf record -e cycles:u ls
perf report --stdio

     75.29%  ls       ld-2.27.so        [.] do_lookup_x
     23.64%  ls       ld-2.27.so        [.] __GI___tunables_init
      1.04%  ls       [unknown]         [k] 0xffffffff85c01210
      0.03%  ls       ld-2.27.so        [.] _start

Looks it's caused by skid.

Thanks
Jin Yao


  reply	other threads:[~2020-02-20 13:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  0:59 Jin Yao
2020-02-20  0:59 ` [PATCH v1 1/2] perf util: Print al_addr when symbol is not found Jin Yao
2020-02-20  0:59 ` [PATCH v1 2/2] perf annotate: Support interactive annotation of code without symbols Jin Yao
2020-02-20 11:56 ` [PATCH v1 0/2] perf report: Support " Jiri Olsa
2020-02-20 12:03   ` Jin, Yao
2020-02-20 12:06     ` Jiri Olsa
2020-02-20 13:50       ` Jin, Yao [this message]
2020-02-20 14:42       ` Jin, Yao
2020-02-20 14:51         ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a0a66ad-e266-b37d-d7ec-e194f2191c2d@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome