From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752674AbeACOD6 (ORCPT + 1 other); Wed, 3 Jan 2018 09:03:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247AbeACOD4 (ORCPT ); Wed, 3 Jan 2018 09:03:56 -0500 Subject: Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency To: Sinan Kaya , Randy Dunlap , eric.auger.pro@gmail.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-acpi@vger.kernel.org" References: <1511370357-17184-1-git-send-email-eric.auger@redhat.com> <48ff2e75-5ee0-5ac9-8d47-58c3c691ad6e@infradead.org> From: Auger Eric Message-ID: <3a0ee0a5-f754-e484-836b-8258d45c2108@redhat.com> Date: Wed, 3 Jan 2018 15:03:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 03 Jan 2018 14:03:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Sinan, On 03/01/18 14:39, Sinan Kaya wrote: > On 1/2/2018 1:19 PM, Sinan Kaya wrote: >> On 1/2/2018 1:10 PM, Randy Dunlap wrote: >>>>> config ACPI_I2C_OPREGION >>>>> bool "ACPI I2C Operation region support" >>>>> - depends on I2C=y && ACPI >>>>> + depends on I2C && ACPI >>>>> default y >>>>> help >>>>> Say Y here if you want to enable ACPI I2C operation region support. >>>>> >>>> Anybody picking this up? >>> Well. It looks to me like the patch is reversed or the patch description >>> needs some improvement. Or I just don't understand it. >> >> I'll let Eric improve the description. >> >> Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected. >> Therefore, any ACPI opregion calls targeting I2C fail with no opregion found. >> >> The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection. >> > > I hope I was able to explain it. =y above is the problem. This config option will only > be selected if module is built-in not for m case. Thank you for your input. I just sent a v2 with reworded commit message. Hope this makes more sense. Thanks Eric >