From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbbEKOFM (ORCPT ); Mon, 11 May 2015 10:05:12 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:34638 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbbEKOFJ (ORCPT ); Mon, 11 May 2015 10:05:09 -0400 From: Michal Simek To: netdev@vger.kernel.org Cc: =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , monstr@monstr.eu, Fabian Frederick , linux-kernel@vger.kernel.org, "David S. Miller" , =?UTF-8?q?Manuel=20Sch=C3=B6lling?= , Julia Lawall , Markus Elfring , Subbaraya Sundeep Bhatta , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] net: ll_temac: Use one return statement instead of two Date: Mon, 11 May 2015 16:05:02 +0200 Message-Id: <3a0fa74dd703db5dac4816ef15b6a512ef0f2ec0.1431353091.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.3.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use one return statement instead of two to simplify the code. Both are returning the same value. Signed-off-by: Michal Simek --- Changes in v2: - Use the same SoB as sender address - Reported-by: Julia Lawall drivers/net/ethernet/xilinx/ll_temac_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 062483f334a5..cfb6bdb37fdc 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -688,10 +688,8 @@ static int temac_start_xmit(struct sk_buff *skb, struct net_device *ndev) cur_p = &lp->tx_bd_v[lp->tx_bd_tail]; if (temac_check_tx_bd_space(lp, num_frag)) { - if (!netif_queue_stopped(ndev)) { + if (!netif_queue_stopped(ndev)) netif_stop_queue(ndev); - return NETDEV_TX_BUSY; - } return NETDEV_TX_BUSY; } -- 2.3.5