mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Prabhakar <prabhakar.csengg@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH] arm64: defconfig: Build STMMAC Ethernet driver into the kernel for NFS boot
Date: Tue, 6 May 2025 12:52:12 +0200	[thread overview]
Message-ID: <3a11ba8a-a9f4-4829-8bcd-56f1702bee8f@linaro.org> (raw)
In-Reply-To: <20250506104731.111876-1-prabhakar.mahadev-lad.rj@bp.renesas.com>

On 06/05/2025 12:47, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Enable `CONFIG_STMMAC_ETH` as built-in (`y`) instead of a module (`m`) to
> ensure the Ethernet driver is available early in the boot process. This
> is necessary for platforms mounting the root filesystem via NFS, as the
> driver must be available before the root filesystem is accessed.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Same comments as for previous patches like this (even the same?): you
are supposed to use initramfs for your arm74 boards. Even armv7 boards
use initramfs, so network driver does not have to be built in.

For example all of our setups use it thus we do not have to populate all
other vendors with our own drivers.

Sorry, but I am strongly against such change. Kernel is already way too
big and with KASAN it does not fit to boot partitions in some of the
devices (and I cannot change the boot partition size, at least not
without big effort).


Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

  reply	other threads:[~2025-05-06 10:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 10:47 Prabhakar
2025-05-06 10:52 ` Krzysztof Kozlowski [this message]
2025-05-06 11:12   ` Lad, Prabhakar
2025-05-06 12:42   ` Geert Uytterhoeven
2025-05-06 13:14     ` Krzysztof Kozlowski
2025-05-23 11:39 ` Geert Uytterhoeven
2025-05-23 11:54   ` Krzysztof Kozlowski
2025-06-12 12:20     ` Jon Hunter
2025-06-12 12:34       ` Geert Uytterhoeven
2025-06-12 13:15         ` Krzysztof Kozlowski
2025-06-12 14:30         ` Thierry Reding
2025-06-19 15:07           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a11ba8a-a9f4-4829-8bcd-56f1702bee8f@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=catalin.marinas@arm.com \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®