From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3190935E55A for ; Mon, 19 Jan 2026 14:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833673; cv=none; b=dY7r1mSAPq3jplL+8QuU3MYND2aR3qfAhdqfvoCwXx8WwI/GJF5l0IvJqGtxTNqiOsLt/5fmzuhN1aOVTndAK/lhGzjY3uwMe+HMZP89hOTj215+tRyDz25RzmvLTWk1Y0Y4hiGXZYiREvw41lpdxhoNVEHL6Jk9S/sCDamD3/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833673; c=relaxed/simple; bh=yg6SXcloJGmJLSUFypYVPsO2vcnz5ICLgzuvBEPL1A4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CKzOG7UJk+qe16Cvwbts+PbnOJuKuiTGPHyCmeWxjkoOB8QPTeoHcW3NVUEWFkaigt3BqrRsqKpAEr9PDxGPBFnedphEruh5YLwx8OQ6y5VZo+BXIrpH41WQlkHaa6g6w9wQ/QOKIB5kH94HYBeYIR8caFUdpBQ/Gqv7ebGO7S8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F/9J/JWq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lig5wHdD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F/9J/JWq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lig5wHdD" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60JA8GXh599507 for ; Mon, 19 Jan 2026 14:41:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7aXbYMXdhaJIz9VzAOKmHA9NGQuHXXe77OASnsSmBNI=; b=F/9J/JWqO7Dnci5Z hiccikZ44wG4TVIPeeAEzIRpadHsn/zH9/0nu+73eQzYDWQoYY6K01MbEz0aQfmc u6c5OLntOqpxIqPTN65i91um3XO0qdAqCZ0X7UIagzyeAMuXj5BFaavcjN0Srdm6 sdNLy5X+VX6m6d0Wkqnh283smKFslLKiB2U92elN4HOhgJnwD7OkcgH4bVwOiCnt Hxt7B0rrJiUZlv2UbnJUkTGGjzfwrbJbibhglqNnHvDJ8ydSDKstg9HOORLymWiJ x4yZBLDiEBrY+R5e+InWD43W4dTrjV0C/CEP2pxlRSpsDWrz4SMp2Ezy/Ust+OU6 5EV/tg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsjk7gs2t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 14:41:10 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c532029e50so154306085a.1 for ; Mon, 19 Jan 2026 06:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768833669; x=1769438469; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7aXbYMXdhaJIz9VzAOKmHA9NGQuHXXe77OASnsSmBNI=; b=Lig5wHdDpCVrtxoFsblq/Pu+4zfV1iMTgvndlCQKYJt+UN7fodEf88yehmNHfF4XL5 g4j40fXW8iw9BqQR3fNnJPFVr9mDAX6qSoYR1F+OBAHkpw+3TDmAvkAsVBEdlD5BZKFb JwVkP81NWZr8Lvb0rhrW9FzhNDyN9xJuq5bhU1mUuBQQSihnC4RgHXVTo6nMK7NcAyim K6AVr0Z9+xOM5etp3E5SshKym71TY0o8wsMxy5XN7uaa8opViXTp7bRyrKrQBNUCRjxM ZKTy94QW33n5CWQawjo24l/1+X19tFMOFu1rFyTHe+rbqMKBqVjizMAsprRkqIZbZ0jV oVeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768833669; x=1769438469; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7aXbYMXdhaJIz9VzAOKmHA9NGQuHXXe77OASnsSmBNI=; b=BGJTN2Q6GplwfvcmBlp5CIcMjMvAZwtrXs8EU/dBQIwa7moOMg9gmepFD4xOYzr6q3 kVAe9+1foQiPBoTtV42LGihK/YK8Mm+FMq90flD38wZsbh89lh09B7N9PTvwCPnAVGET g1dY3sWpcgKxJiI96NsEMZ55eEG+QQ0u0u7XQW6OcOdPg7QHZbBDHiCGHBdsiRdqqE3U TgjP2ug2usoWbF1/TWUvhcOU5mlOkbyRd3oYO/KaeEw0P9NR7j1kOhtBX7G9JxL/hc3+ qDlZLJwlDh7tTFaZ+dAEFC27fyXlZHS6S9wnei1lQa/gu+Nqy8D13+LOgPMCGTeWErv8 Aw3w== X-Forwarded-Encrypted: i=1; AJvYcCUOb48wkyNId5VYI1dZHabI6+7xTC/J5fY/r7W+7IXSYiIPNEz5ZRfvfPvrA+b5SZ59jXsA8CTx+28eYEY=@vger.kernel.org X-Gm-Message-State: AOJu0YzwKN6WChmnVl2M1mzEHPmyGHrCfQPivig2o8LFxNQWiphttYma VJcAOZfQjegCuFFdWo8viT2zDV47JIhKn9likzdTcuyfbCbVNOI8aG0KYV6ccqHYm8zB4CZQxvX B3rmV+WJ8O6PZ02Lb/KBIdRhqNJ0tBxL1XqJNaSb5qGoUsLW0wxRgnafk78oceMVfMN4= X-Gm-Gg: AY/fxX4ulTpOE8Zq/pR1Jgs91nqIFmacg+pSlLGDw+S9YlzTYKfkIazY1EapZJQWoPw v1xK2E9zUQZZlyxlquaoBTODNq4mSz3XwWC1yqQ2dctH4IgJrrcuiQRmBUo5Pm1uhcHQgVZp4r8 e6S5jnuTva262HglEgpfqfSfj54T+TPJpaRq5/SsjlusTuf9L8e2cUSWAYxkAV/GKzmIvuUM8JF hzwRhIqJ8FaqIVaq5PWrJDuotTRN/P8sNolXvRC55ZHgX44A/OFPAncRlLT1oim/GRagMhQ7XZV BgZ43cMsuFnayx506plTooVr100O1dnHhHn8RlHpT+0E0yMST8voik3+b0R9Naex+/srRtUWmgR bycEWUBzkecfVFB9eryurxewnI/5gExRXjgIo8eSft66NhLsbVxQtjIP0uxfM2wDmQRc= X-Received: by 2002:a05:620a:2a05:b0:8b2:e177:fb18 with SMTP id af79cd13be357-8c6a67bc788mr1133449985a.9.1768833669368; Mon, 19 Jan 2026 06:41:09 -0800 (PST) X-Received: by 2002:a05:620a:2a05:b0:8b2:e177:fb18 with SMTP id af79cd13be357-8c6a67bc788mr1133447285a.9.1768833668948; Mon, 19 Jan 2026 06:41:08 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795168c7bsm1178573966b.20.2026.01.19.06.41.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 06:41:08 -0800 (PST) Message-ID: <3a17f2e5-0724-4d70-bd22-1e612142b3e8@oss.qualcomm.com> Date: Mon, 19 Jan 2026 15:41:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: milos-fairphone-fp6: Add Hall Effect sensor To: Luca Weiss , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260116-fp6-hall-sensor-v1-1-69275c6bd809@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260116-fp6-hall-sensor-v1-1-69275c6bd809@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDEyMyBTYWx0ZWRfX6vPmVJ/2Sc9a YaK45ocL2VXM5WGYebaO9AXlQtJ8WMShBIgge5tlRPuC7LHRVeX8kD8B4ycqGRCC4VTgPjawPPV 7FfwkQZH3i6TzxBAXXVk639rtxQmZfpgpwsogmtD7U0hUGIC/fNpwTyrR3Pw+b6iXSos7TOF7AJ OyNWXncw16/G/ZV5AWr6avJGWGYcBnbYulEADJc7TXbjwGpWtH38ssLcc3bOH1zpUfzkzbMTqlc dQajwK574YteUioQTdyuoQ2JTp+82Wtn2dk506RP7m6d25OnhOnnS/1+xStVUZwuvj9W2Rd1YEW BNTsNheAzSY3YG314MRpbWuLX8+U++JQmg/Hqb9nxu1rMve8UzGtGZIHpZndkSm+w0rnDUpfHr0 YVl29+XRRwRGwdRUXyKwSSQhQNLawbwvnBL58oXoj472yUPTx8nrY9RJE/mimvtNrlWiieAigGM y0/jTVNcS13JNQCDKIw== X-Proofpoint-ORIG-GUID: XNvvC0SxpE5wmcx0hNkTJk2elsVufEO6 X-Authority-Analysis: v=2.4 cv=WoAm8Nfv c=1 sm=1 tr=0 ts=696e4286 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=6H0WHjuAAAAA:8 a=p04JXNiKSxiIgApV0UoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: XNvvC0SxpE5wmcx0hNkTJk2elsVufEO6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_03,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190123 On 1/16/26 3:22 PM, Luca Weiss wrote: > Add a node for the Hall Effect sensor, used to detect whether the Flip > Cover is closed or not. > > The sensor is powered through vreg_l10b, so let's put a > regulator-always-on on that to make sure the sensor gets power. Is there anything else on L10B? Can we turn it off if the hall sensor is e.g. user-disabled? Konrad > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > index 7629ceddde2a..98b3fc654206 100644 > --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > @@ -32,6 +32,16 @@ gpio-keys { > pinctrl-0 = <&volume_up_default>; > pinctrl-names = "default"; > > + /* Powered by the always-on vreg_l10b */ > + event-hall-sensor { > + label = "Hall Effect Sensor"; > + gpios = <&tlmm 70 GPIO_ACTIVE_LOW>; > + linux,input-type = ; > + linux,code = ; > + linux,can-disable; > + wakeup-source; > + }; > + > key-volume-up { > label = "Volume Up"; > gpios = <&pm7550_gpios 6 GPIO_ACTIVE_LOW>; > @@ -316,6 +326,8 @@ vreg_l10b: ldo10 { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > regulator-initial-mode = ; > + /* Hall sensor VDD */ > + regulator-always-on; > }; > > vreg_l11b: ldo11 { > > --- > base-commit: ef1c7b875741bef0ff37ae8ab8a9aaf407dc141c > change-id: 20260116-fp6-hall-sensor-1049f2f872ac > > Best regards,