From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Yauhen Kharuzhy <jekhor@gmail.com>
Cc: <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Mark Brown <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v3 2/3] ASoC: Intel: soc-acpi-cht: Add Lenovo Yoga Book entries
Date: Thu, 11 Jun 2026 10:50:32 +0200 [thread overview]
Message-ID: <3a18dd98-7ce6-4b41-ac42-4bc0d3ac43a3@intel.com> (raw)
In-Reply-To: <20260611-asoc-yogabook-v2-v3-2-3128447b67b6@gmail.com>
On 6/11/2026 1:51 AM, Yauhen Kharuzhy wrote:
> Lenovo Yoga Book YB1-X91 device uses a Cherry Trail SoC and has a valid
> ACPI DSDT entry for the RT5677 codec. This entry has some non-standard
> resource definitions, such as jack detection chip information, and
> hardware has some additional GPIO controls so use 'cht-yogabook'
> for the driver name instead of some default (like 'cht-bsw-rt5677').
...
> diff --git a/sound/soc/intel/common/soc-acpi-intel-cht-match.c b/sound/soc/intel/common/soc-acpi-intel-cht-match.c
> index 28f600171f9d..5e8a1dc84ee1 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-cht-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-cht-match.c
...
> @@ -121,6 +147,20 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cherrytrail_machines[] = {
> .board = "cht-bsw",
> .sof_tplg_filename = "sof-cht-rt5670.tplg",
> },
> + /*
> + * The only known Cherry Trail device with RT5677 codec and 10EC677
> + * DSTD entry is the Lenovo Yoga Book YB1-X91. It has a device-specific
> + * driver, so check DMI and use a machine quirk to override the default
> + * (non-existent) machine driver.
> + */
> + {
> + .id = "10EC5677",
> + .drv_name = "cht-bsw-rt5677",
> + .fw_filename = "intel/fw_sst_22a8.bin",
> + .board = "cht-bsw",
> + .machine_quirk = cht_quirk,
> + .sof_tplg_filename = "sof-cht-rt5677.tplg",
The cover letter reads:
v3:
(...)
- Remove support for SOF;
and yet here you're assigning .sof_tplg_filename.
> + },
> {
> .comp_ids = &rt5645_comp_ids,
> .drv_name = "cht-bsw-rt5645",
>
next prev parent reply other threads:[~2026-06-11 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 23:51 [PATCH v3 0/3] Add ASoC machine driver for Cherryview tablets with RT5677 Yauhen Kharuzhy
2026-06-10 23:51 ` [PATCH v3 1/3] ASoC: Intel: soc-acpi-cht: Unify device quirks Yauhen Kharuzhy
2026-06-11 8:47 ` Cezary Rojewski
2026-06-11 14:10 ` Mark Brown
2026-06-11 18:05 ` Yauhen Kharuzhy
2026-06-11 18:12 ` Mark Brown
2026-06-10 23:51 ` [PATCH v3 2/3] ASoC: Intel: soc-acpi-cht: Add Lenovo Yoga Book entries Yauhen Kharuzhy
2026-06-11 8:50 ` Cezary Rojewski [this message]
2026-06-10 23:51 ` [PATCH v3 3/3] ASoC: Intel: Add cht_rt5677 driver Yauhen Kharuzhy
2026-06-11 9:19 ` Cezary Rojewski
2026-06-11 21:53 ` Yauhen Kharuzhy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a18dd98-7ce6-4b41-ac42-4bc0d3ac43a3@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=hansg@kernel.org \
--cc=jekhor@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®