From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA2FC433E1 for ; Tue, 30 Mar 2021 19:49:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E343619B9 for ; Tue, 30 Mar 2021 19:49:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233253AbhC3Tt1 (ORCPT ); Tue, 30 Mar 2021 15:49:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54963 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233204AbhC3Ts4 (ORCPT ); Tue, 30 Mar 2021 15:48:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617133735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OzWHBGLRQSImyi4e0nOZKdQoWKxewGVgAE+CFb4wwPc=; b=iSlCGRs6VCjQoCeBwC0vXZ0lDdqTqqW3cQT5ZJy9e9xTJ2Hp9tMYBi+gH4uaHVycwz2wQC 0SgkHVHjJFNnhaWQLAgOU++Cdhi5uNX/riq3rBL00yFO37amxwAzIu5uEiDhZPEtebPK0U 7KAq4R3SdvXRzm85kUAmme1vH0pLPyM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-1htU5wx-N1SSKQxQ-_uhag-1; Tue, 30 Mar 2021 15:48:54 -0400 X-MC-Unique: 1htU5wx-N1SSKQxQ-_uhag-1 Received: by mail-wr1-f69.google.com with SMTP id r12so10851096wro.15 for ; Tue, 30 Mar 2021 12:48:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OzWHBGLRQSImyi4e0nOZKdQoWKxewGVgAE+CFb4wwPc=; b=H+yKtlzaAFgRVR4XTDe8RjsHBLHQhzZtPrQujnmJG1aI4FMxK3rKgKre/G2aruZH5z vvTf1YUtg7S+JyGqbMvINWADdcPlhgUxM2QjGzaAtSv/9ceveB4UbURmM/UPv8koCfuw fFfSg8eRw1lP4lz3HMbRpE6tN/vx11YCcI+MVJ0sjr9d3c96G9wCx3scoW9+08gaZcoW ZIdb6w++naaTCxsZ3Q/y+JudAV+N9rVkfPMrk2pV41+PNqoZ6yaU5PMLz3vyl8ByE8gN g6d2n+sbQ4QECjYIiSXAgtxhrIByNo8ZXDYFLXxRnVaEKtJ87CXPPlsxC/aqz1D0h5hh oFoA== X-Gm-Message-State: AOAM530SLXHH2Efbcc0ZMQ1wz5o2Voofhu79biwPQb1vKatt9+L4mVsF kKJtqP1HVvJfWWTW6z9mTrd4ZPdDr/+QMzbzrLQ/ZrwZ65Exx8PUOqlF42AK1iCE4Md3ccTojDA rF2LQPq71LnH0n/OR6HEcxF+gDfc02KWhEgD9IQDmuhFounRCv7xnwvA8aUTHUNxyF19vM5+qLE lK X-Received: by 2002:a7b:c0c3:: with SMTP id s3mr5514408wmh.11.1617133732385; Tue, 30 Mar 2021 12:48:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrWDuYw2HfRbOt7weQUpuJCXUwrbqFmeFadK3gLejd+/RrcU8+0Fo4iU0Fj3iEAf2A+hbNXA== X-Received: by 2002:a7b:c0c3:: with SMTP id s3mr5514373wmh.11.1617133732072; Tue, 30 Mar 2021 12:48:52 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id w11sm37459472wrv.88.2021.03.30.12.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Mar 2021 12:48:50 -0700 (PDT) Subject: Re: [PATCH 00/18] KVM: Consolidate and optimize MMU notifiers To: Ben Gardon , Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm , kvm-ppc@vger.kernel.org, LKML References: <20210326021957.1424875-1-seanjc@google.com> From: Paolo Bonzini Message-ID: <3a1dd877-7421-7628-4214-30483c4de10f@redhat.com> Date: Tue, 30 Mar 2021 21:48:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/03/21 20:32, Ben Gardon wrote: >> Patches 1-7 are x86 specific prep patches to play nice with moving >> the hva->gfn memslot lookups into common code. There ended up being waaay >> more of these than I expected/wanted, but I had a hell of a time getting >> the flushing logic right when shuffling the memslot and address space >> loops. In the end, I was more confident I got things correct by batching >> the flushes. >> >> Patch 8 moves the existing API prototypes into common code. It could >> technically be dropped since the old APIs are gone in the end, but I >> thought the switch to the new APIs would suck a bit less this way. > Patches 1-8 look good to me. Feel free to add my Reviewed-by tag to those. > I appreciate the care you took to make all those changes tiny and reviewable. > Just finished reviewing that part too, they were very nice and I've queued them. I'll continue tomorrow with the rest. Paolo