From: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
Shawn Guo <shawn.guo@linaro.org>, Marc Zyngier <maz@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/9] irqchip/irq-qcom-mpm: Program wakeup timer when CPU cluster goes to LPM
Date: Tue, 27 Oct 2026 17:03:55 +0530 [thread overview]
Message-ID: <3a1f6a65-4406-484b-a2cd-00019149d4a1@oss.qualcomm.com> (raw)
In-Reply-To: <b833f6f9-5729-4936-8c5b-cd42d32c5198@oss.qualcomm.com>
On 19-10-2026 17:26, Konrad Dybcio wrote:
> On 10/15/26 11:55 AM, Sneh Mankad wrote:
>> The next wakeup timer value needs to be set in MPM timer as the arch timer
>> interrupt can not wakeup the SoC if after the deepest CPUidle states the
>> SoC also enters deepest low power state.
>>
>> To wakeup the SoC in such scenarios the earliest wakeup time is set in MPM
>> timer and the Resource Power Manager (RPM processor) takes care of setting
>> the timer in HW.
>>
>> Add MPM timer programming when CPU cluster enters power collapse.
>>
>> Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
>> ---
>
> [...]
>
>> +static void mpm_write_next_wakeup(struct qcom_mpm_priv *priv)
>> +{
>> + ktime_t now, wakeup = KTIME_MAX;
>> + u64 wakeup_us, wakeup_cycles = ~0;
>> + u32 lo, hi;
>> +
>> + /* Set highest time when system (timekeeping) is suspended */
>> + if (system_state == SYSTEM_SUSPEND)
>> + goto exit;
>> +
>> + /* Find the relative wakeup in kernel time scale */
>> + wakeup = dev_pm_genpd_get_next_hrtimer(priv->dev);
>
> This returns KTIME_MAX after the DT patches in this series are merged
> (because there's no power_domain that the MPM hangs off of anymore)
Yes that is true, thanks for pointing out. Perhaps we will revisit the timer changes
once we manage to add MPM device under CPU cluster power domain without blocking cluster
LPMs. For now will drop them from revised series.
Thanks,
Sneh
next prev parent reply other threads:[~2026-10-27 11:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 9:55 [PATCH v2 0/9] Add fallback method to handle RPM notification in MPM driver Sneh Mankad
2026-10-15 9:55 ` [PATCH v2 1/9] arm64: dts: qcom: shikra: Add CPU idle states Sneh Mankad
2026-10-20 12:58 ` Abel Vesa
2026-10-20 13:59 ` Konrad Dybcio
2026-10-27 5:49 ` Sneh Mankad
2026-10-15 9:55 ` [PATCH v2 2/9] irqchip: irq-qcom-mpm: Register MPM with cpu_pm for RPM notification Sneh Mankad
2026-10-19 11:10 ` Konrad Dybcio
2026-10-27 12:39 ` Sneh Mankad
2026-10-19 11:24 ` Konrad Dybcio
2026-10-15 9:55 ` [PATCH v2 3/9] arm64: delay: Move USECS_TO_CYCLES() to generic header Sneh Mankad
2026-10-15 9:55 ` [PATCH v2 4/9] irqchip/irq-qcom-mpm: Prepare common access path for timer and pin regs Sneh Mankad
2026-10-19 11:19 ` Konrad Dybcio
2026-10-15 9:55 ` [PATCH v2 5/9] irqchip/irq-qcom-mpm: Program wakeup timer when CPU cluster goes to LPM Sneh Mankad
2026-10-19 11:56 ` Konrad Dybcio
2026-10-27 11:33 ` Sneh Mankad [this message]
2026-10-15 9:55 ` [PATCH v2 6/9] arm64: dts: qcom: sm6375: Do not mark MPM as a power domain provider Sneh Mankad
2026-10-20 13:00 ` Abel Vesa
2026-10-27 5:53 ` Sneh Mankad
2026-10-27 10:59 ` Abel Vesa
2026-10-27 13:12 ` Sneh Mankad
2026-10-15 9:55 ` [PATCH v2 7/9] arm64: dts: qcom: agatti: Do not mark MPM as " Sneh Mankad
2026-10-15 9:55 ` [PATCH v2 8/9] arm64: dts: qcom: qrb2210-rb1: Enable CPU cluster low power mode Sneh Mankad
2026-10-15 9:55 ` [PATCH v2 9/9] arm64: dts: qcom: shikra: Do not mark MPM as power domain provider Sneh Mankad
2026-10-20 13:59 ` Konrad Dybcio
2026-10-27 5:48 ` Sneh Mankad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a1f6a65-4406-484b-a2cd-00019149d4a1@oss.qualcomm.com \
--to=sneh.mankad@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frederic@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®