From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B67532C329 for ; Fri, 13 Feb 2026 08:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770971351; cv=none; b=GzrlEOxobzSbaL8qa2vFKsqocnXVSdvwviq37uDpa/Ej2LInOILj7xtTJEOCf8y1n3hMPf8bJLOCYmglsmnhqU53sRDhQRatZEIDO8RxBXF36XDRtGvZVqgOKFpAK2GsUiMfiY57GZMoSgfqGMtXJ0HjXpVkHRv6fRFxRW7cUtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770971351; c=relaxed/simple; bh=zvgY37ZQjsQkz5/m86ybqaE+gQvu4wV1jaVZs1RK1Mg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AFYpI2NIeVkBzm8cVnwwUaWWJcNcFKe6eLJJ7Bi+HQjnBsxA15Ki/BF5nj0ZO8934bQV6Pu1ic6bvRhzVzLW1vvvtvS7hixy4c9xPVGBeHEE/LWBgZWfqcBwNPBQx/ZyNbUCDf3a1xhn3+ovwOpNr+7nsHW6zPkBLCZO6yR/dxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LUH/sthl; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LUH/sthl" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-79456d5ebf9so7620637b3.2 for ; Fri, 13 Feb 2026 00:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770971348; x=1771576148; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eb9SMDXx3XqEdbaMIOBwU3P2hDpL6y884kxQ2eGE+V0=; b=LUH/sthltK7mdMPmTGL23mil49iTOSK39JeJJz0oPrCtjEfHzeuyC3SS2YicDeHoK/ 3lAN4qUDX0eHnWBOJnPbEmQvXn8FymgTb3nDSDqdvQvYBOgR3okiDmzdda4vXOvl00i9 Q4Ko1cJRYXtANJX34C/HTDbP+t8PrzWnuJKWsSf9xyE0rHcDToOfv6jrQPjAVu3rcWW8 vaPAQqJ6I/Utr6yTTRHqgg+qNU+D9YiuBgh5f/fO0+2wCJieSUFtrT8sKQLck3u2Xkke GI1JJaljMOWtal098eVwPi/e/mUiYZ0CL5w1+I0uNVAeVVK78bAfEuiTaVNoemnIA0x9 uAqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770971348; x=1771576148; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eb9SMDXx3XqEdbaMIOBwU3P2hDpL6y884kxQ2eGE+V0=; b=vieQvCxQndlcx4kvGuc9TprBLkKH/R7p0PMLirVuq4j1CIWqnygfJf7ZFEkrjFLxs+ mZsNb84jadr1KHMNkuOsskbQj+bvhTgYu4RPXyeltwVxVoLN0lRjaf0mZRfXEsnTBNU4 Fq95E4niqX3XLsBsmJed9b7S6ob4PyK6K0a+OdQ+a7YyGW0/9hrtBjA7FxEnDwAMOXvt luxB0aRO0T/svHnn6ae46I3hACpW4RjQxXamyjMmPxaYn38RtIOynuoDRAIyAjrfC+IY bcOtlYf3JHUgYdfx2H+YqSMhh2zcc2c4v/N1CYeeMbdk9lW1zyoV3ONXIXqrWIvZpDta flRw== X-Forwarded-Encrypted: i=1; AJvYcCUDYlOVXHC/eTyAzekuO+elERMF+nl/RK6jztY7F6dx9fN9/T2F5hUh3To0FYopYC5Q0lMx1LVEy5u/crk=@vger.kernel.org X-Gm-Message-State: AOJu0YzI/dm25q7ZhN22pt2IbsWOr6SkV3Pr3kHM3VkVXL7Q1OHyCl0N 5TAuLX49JDe6u66YkyqRriHRqzwAJDsS9PrScVTRZmmIo4qJYcfiO7dN X-Gm-Gg: AZuq6aLeNvSYyLyldeOEBjLc9WKY9M+/8cWTSPDu0uicQ7cjQM6IqxfoFpo+H0ePWxJ 9Sjk/fa8kSubdU8SLVb+BInmkz3kXNQJELJ/Z8fXXtzwvWwQJW6qG45idROtIQS0QimpUZ5itrX tJgfzkp7v9SORSLsZ1hHj3Eggh22GXr9lmWcvdZ7027O65IBFETUs/zi8R8ZbrKX4qr6PMCR2TD FETWUwu/eTX13AiYj6irvdrjWUOhXeJiOeiPh46GJkz5WBa9m9CgyBamHa0+uTLpXmyqmlN1YRb DEFtM/GsWeuDEOS6O/4Koww4fKq9pXtLtzMT0UsGLzmBWdnOH2mBzel7bnAuHT0Pok5kaqSeXNK r7ZMrv2NXWNp3i835b1rHDbKMKLp3tsJk7UZBCMRQLXuGIqsx/DTRSmGqflIUPbbliFGCyA/ITx CeAOoulmE0XEPZYgtCvC8nzU/LhA== X-Received: by 2002:a05:690c:6306:b0:78a:859c:63b2 with SMTP id 00721157ae682-797a0c22868mr8571517b3.30.1770971348077; Fri, 13 Feb 2026 00:29:08 -0800 (PST) Received: from [192.168.0.40] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c254d1esm64369077b3.41.2026.02.13.00.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 00:29:07 -0800 (PST) Message-ID: <3a20c906-647c-458f-a118-c7927495e7ef@gmail.com> Date: Fri, 13 Feb 2026 10:29:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P To: Krzysztof Kozlowski Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260212-cm36686-v4-0-8f587d4a72bf@gmail.com> <20260212-cm36686-v4-1-8f587d4a72bf@gmail.com> <20260213-unyielding-pistachio-ape-deda74@quoll> From: Erikas Bitovtas Content-Language: en-US In-Reply-To: <20260213-unyielding-pistachio-ape-deda74@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/13/26 9:54 AM, Krzysztof Kozlowski wrote: > On Thu, Feb 12, 2026 at 04:42:47PM +0200, Erikas Bitovtas wrote: >> Capella CM36686 is an ambient light and proximity sensor developed by >> Capella Microsystems, now a subsidiary of Vishay Intertechnology Inc. It >> has an I2C address of 0x60 and is fully compatible with an existing >> driver for VCNL4040. > > I wonder why and how... VCNL4040 shares the same digital interface as CM36686. All the registers and their fields are the same. It is most likely Vishay just reused the CM36686 design for VCNL4040. > >> Capella CM36672P is a proximity-only sensor that >> is fully compatible with CM36686, and therefore with VCNL4040. Add >> compatibles for cm36672p and cm36686, with a fallback for cm36686 of >> vcnl4040. >> >> Signed-off-by: Erikas Bitovtas >> --- >> .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 17 +++++++++++------ >> 1 file changed, 11 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> index 4d1a225e8868..2ba4d5de4ec4 100644 >> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> @@ -18,12 +18,17 @@ allOf: >> >> properties: >> compatible: >> - enum: >> - - vishay,vcnl4000 >> - - vishay,vcnl4010 >> - - vishay,vcnl4020 >> - - vishay,vcnl4040 >> - - vishay,vcnl4200 >> + oneOf: >> + - enum: >> + - capella,cm36672p > > CM36672P is compatible with CM36686, but this is not expressed. > Confusing commit msg and code. For CM36672P we create a dedicated compatible because it is a proximity-only sensor which has the same proximity sensor configuration, but ambient light sensor registers are missing (reserved). >> + - vishay,vcnl4000 >> + - vishay,vcnl4010 >> + - vishay,vcnl4020 >> + - vishay,vcnl4040 > > Best regards, > Krzysztof >