From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
seanjc@google.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Do not return host topology information from KVM_GET_SUPPORTED_CPUID
Date: Wed, 25 Jan 2023 15:17:30 +0100 [thread overview]
Message-ID: <3a23db58-3ae1-7457-ed09-bc2e3f6e8dc9@redhat.com> (raw)
In-Reply-To: <CALMp9eQihPhjpoodw6ojgVh_KtvPqQ9qJ3wKWZQyVtArpGkfHA@mail.gmail.com>
On 1/25/23 00:16, Jim Mattson wrote:
> This is a userspace ABI change that breaks existing hypervisors.
> Please don't do this. Userspace ABIs are supposed to be inviolate.
What exactly is broken?
Part of the definition of the API is that you can take
KVM_GET_SUPPORTED_CPUID and pass it to KVM_SET_CPUID2 for all vCPUs.
Returning host topology information for a random host vCPU definitely
violates the contract.
Furthermore, any existing userspace should be prepared to deal with
nonexistent host topology leaves. If you mean that said userspace would
now pass no topology to the guest, that's not an API change either.
(Now, there are certainly other parts of the KVM_GET_SUPPORTED_CPUID
contract that should be specified better. But that should be done for
each leaf one by one, which I intend to do, and would not extend to
these three host topology leaves).
Paolo
next prev parent reply other threads:[~2023-01-25 14:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 9:20 Paolo Bonzini
2023-01-24 23:16 ` Jim Mattson
2023-01-25 14:17 ` Paolo Bonzini [this message]
2023-01-25 16:47 ` Jim Mattson
2023-01-25 21:46 ` Paolo Bonzini
2023-01-25 22:09 ` Jim Mattson
2023-01-25 22:43 ` Paolo Bonzini
2023-01-26 0:58 ` Jim Mattson
2023-01-26 9:40 ` Paolo Bonzini
2023-01-26 16:06 ` Jim Mattson
2023-01-26 17:47 ` Paolo Bonzini
2023-01-26 20:45 ` Jim Mattson
2023-01-27 7:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a23db58-3ae1-7457-ed09-bc2e3f6e8dc9@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®