From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933888AbcJMC1w (ORCPT ); Wed, 12 Oct 2016 22:27:52 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:36539 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933064AbcJMC1v (ORCPT ); Wed, 12 Oct 2016 22:27:51 -0400 X-AuditID: cbfee61a-f79786d000004c78-8b-57fef10c7ab2 Subject: Re: [RFC v2 1/2] sdhci: Add device tree property broken-highspeed To: Zach Brown , ulf.hansson@linaro.org References: <1476297656-7019-1-git-send-email-zach.brown@ni.com> <1476297656-7019-2-git-send-email-zach.brown@ni.com> Cc: adrian.hunter@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Jaehoon Chung Message-id: <3a259c3a-6b5e-2464-8402-488b13f03730@samsung.com> Date: Thu, 13 Oct 2016 11:27:23 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1476297656-7019-2-git-send-email-zach.brown@ni.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t9jAV2ej//CDdrP8VmcfLKGzWL+kXOs Fpd3zWGzOPK/n9Fi6fWLTBate4+wWxxfG27xan+cA4fHmnlrGD0W73nJ5LFpVSebx51re9g8 rp/ZzuTxeZNcAFuUm01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJO KZBnZIAGHJwD3IOV9O0S3DIWnrvDXvCBr+L9303sDYxLeLoYOTkkBEwkViz8zQRhi0lcuLee rYuRi0NIYCmjxN/rJ9ghnAeMEjcPNwM5HBzCAl4SV97mgjSICFhJHFtyDarhNKPEwpn/WUAc ZoF5jBJrVm1mAaliE9CR2P7tONgKXgE7ifMzFzGD2CwCqhLNyz+AxUUFwiROnjvHDlEjKPFj 8j2wXk4BR4nZR9YygixmFlCXmDIFbDGzgLzE5jVvmScwCsxC0jELoWoWkqoFjMyrGCVSC5IL ipPScw3zUsv1ihNzi0vz0vWS83M3MYJj7pnUDsaDu9wPMQpwMCrx8Frc+hcuxJpYVlyZe4hR goNZSYS36xlQiDclsbIqtSg/vqg0J7X4EKMp0BsTmaVEk/OB6SCvJN7QxNzE3NjAwtzS0sRI SZy3cfazcCGB9MSS1OzU1ILUIpg+Jg5OqQZGjVDb7ZHM6hMNW545yZ1YbvZl1vkPm77cMyiZ t6Mx773h53z5MzFXDq+78eWFx99LmoveRj2XWs5hed+uS7hA/0rtZJbFT/pjruTYbqn7PO/k NGG/0DYL+/8umtm2j3bqXvB7PfWatdXRHE27Hmnzp1qvq5IZw4uuz9KfHWg/w/H/kYl3u2wL lFiKMxINtZiLihMBGpvzrc8CAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2016 03:40 AM, Zach Brown wrote: > Certain board configurations can make highspeed malfuction due to timing > issues. In these cases a way is needed to force the controller and card > into standard speed even if they otherwise appear to be capable of > highspeed. I'm not sure "broken-hishspeed" property is relevant to only sdhci driver? otherwise on card side..? Subject looks like only sdhci driver..And your RFC patch should be supported only SDHCI driver. But your [patch 1/2] can cause the confusing in future..because there are just comment as "controller". Then developer who refer to mmc.txt will add the property "broken-highspeed". I'm not sure what is correct way..but to prevent confusing..you mentioned only "sdhci" driver or supporting other controller. Best Regards, Jaehoon Chung > > The broken-highspeed property will let the sdhci driver know that > highspeed will not work. > > Signed-off-by: Zach Brown > --- > Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt > index 8a37782..a2b298c 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/mmc.txt > @@ -52,6 +52,8 @@ Optional properties: > - no-sdio: controller is limited to send sdio cmd during initialization > - no-sd: controller is limited to send sd cmd during initialization > - no-mmc: controller is limited to send mmc cmd during initialization > +- broken-highspeed: Highspeed is broken, even if the controller and card > + themselves claim they support highspeed. > > *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line > polarity properties, we have to fix the meaning of the "normal" and "inverted" >