From: "Uli v. d. Ohe" <u-v@mailbox.org>
To: jkosina@suse.com
Cc: benjamin.tissoires@redhat.com, iam@valdikss.org.ru,
jekhor@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, me@khvoinitsky.org
Subject: Re: [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd
Date: Fri, 22 Dec 2023 16:32:07 +0100 [thread overview]
Message-ID: <3a29c0a6-9b53-433d-a83d-5b68a87c1155@mailbox.org> (raw)
In-Reply-To: <nycvar.YFH.7.76.2312121445510.24250@cbobk.fhfr.pm>
I get buggy middle button scrolling behavior on my USB Compact Keyboard
(i.e., "1st gen") with original, unmodified firmware and the patch (of
Sep. 23).
Sometimes the keyboard sends REL_X events while the middle button is
pressed. Thus the old "workaround" is disabled and middle button
scrolling henceforth exhibits the known buggy behavior.
Explicitly, I can confirm that the following values occur, leading to
erroneous disabling of the workaround:
cptkbd_data->middlebutton_state == 1
usage->type == 2 [i.e., EV_REL]
usage->code == 0 [i.e., REL_X]
The keyboard is identified by lsusb as:
ID 17ef:6047 Lenovo ThinkPad Compact Keyboard with TrackPoint
This was tested with kernel 6.1.67 which contains the backported patch
(commit 6e2076cad8873cc2a9f96e4becab35425c3656dc).
I didn't test the latest patch of Dec. 12. However, I don't expect it to
fix my issue as the only added condition
hdev->product == USB_DEVICE_ID_LENOVO_CUSBKBD
should be satisfied, which I understand is also the intention.
(USB_DEVICE_ID_LENOVO_CUSBKBD == 0x6047, which is the device ID of my
keyboard as reported by lsusb.)
Best regards,
Uli
next prev parent reply other threads:[~2023-12-22 15:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 14:50 [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd Mikhail Khvainitski
2023-09-23 22:58 ` Mikhail Khvainitski
2023-09-23 22:58 ` [PATCH] HID: lenovo: Detect quirk-free fw on cptkbd and stop applying workaround Mikhail Khvainitski
2023-10-04 19:02 ` Jiri Kosina
2023-12-09 12:50 ` Yauhen Kharuzhy
2023-12-09 16:56 ` Yauhen Kharuzhy
2023-12-09 18:21 ` Yauhen Kharuzhy
2023-12-11 16:17 ` Mikhail Khvoinitsky
2023-12-12 13:31 ` [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd Mikhail Khvainitski
2023-12-12 13:45 ` Jiri Kosina
2023-12-22 15:32 ` Uli v. d. Ohe [this message]
2023-12-23 18:04 ` Mikhail Khvoinitsky
2023-12-23 19:12 ` [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd Mikhail Khvainitski
2024-01-23 10:55 ` Jiri Kosina
2023-12-24 15:51 ` [PATCH] HID: lenovo: Restrict detection of patched firmware only to USB cptkbd Uli v. d. Ohe
2023-12-26 9:36 ` Yauhen Kharuzhy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a29c0a6-9b53-433d-a83d-5b68a87c1155@mailbox.org \
--to=u-v@mailbox.org \
--cc=benjamin.tissoires@redhat.com \
--cc=iam@valdikss.org.ru \
--cc=jekhor@gmail.com \
--cc=jkosina@suse.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@khvoinitsky.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®