From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750879AbdKSGia (ORCPT <rfc822;w@1wt.eu>);
        Sun, 19 Nov 2017 01:38:30 -0500
Received: from mout.web.de ([212.227.15.14]:51639 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750744AbdKSGi2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 19 Nov 2017 01:38:28 -0500
Subject: Re: [PATCH] ALSA: via82xx: Use common error handling code in
 snd_via82xx_create()
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Julia Lawall <Julia.Lawall@lip6.fr>, Jaroslav Kysela <perex@perex.cz>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <2332472c-61d2-8c21-bf46-5c80745d6380@users.sourceforge.net>
 <s5hpobnscx1.wl-tiwai@suse.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <3a2f0905-231d-b2af-d1e8-1635158c6e53@users.sourceforge.net>
Date: Sun, 19 Nov 2017 07:37:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <s5hpobnscx1.wl-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:qeevDx7Me1sPtm4YAO+mpK6Nw7ETpo92m7rdGhnquCrFln63Pwg
 j/UIQmFBFso8errzoW+9JByMkKBmAIR6dIIo6x5tb4ZiK51VgHFacXbloCgQhvDlQ29YieS
 5un7UcijyvwB01H+E9b1vx0LOMZtgFWY6K8xpo/MEEfNFe9ulhCLJW99W+W+8+THpk+dPyq
 1Mt9xyUoc50EosAVWB15A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:FP4vFHP/HBo=:paBCxwE9gauK27ifYPmoe+
 Ow4+oNwm7O3DmziNqo2q78zZtve4r9qsowCySKeuHsiQEYaCgfcOlAUsLgAQyvkNpuXPrvGD7
 EJ2hkiRcXofpMEENTUt3/GbUscTkKY3Gr6dHxcxf/uMLjq1B7OzzvdInFJQ4t7y5MYhWrGQ9O
 fX4Ft8JXKAapncSZCGl3mn66vMVqLmAEFloDlo5VdWZgwZugEKQz6keiD7zQkjUv7TtS+qYGJ
 tRX134z42x9txriGRepIiSjH+v51Xdp+M5Ds8PyY8eUw91acFHK4rNNW/YyBOw8ZE4F/WfTe7
 opz0EtxJM1YBZ9V7o5/eClfvUma7JCFrVWJPUXWkOO4XxEsydShpdx6nbZYmsVJJXbNMgJynZ
 PdCUEs2jD78Ik7hoEaNU0zHFj+5LERSih2BaNk05ngxy+oFy84x9T624LVozdIfNxX/T4fvpg
 lX5TPI4AeprfPWZZuINcjeW8JqjjWd7RHAyzFndsJYFYsmTeHJnkRlJsE9JJaGYuLEbCfs7jS
 Dvk27fSuF710twu1y8KXXEXybV79MvXbaU9D4NGWlRxex3CmjjOfi6uwlMUgd277r+zf4rG3O
 eY5/Op7aUIK35P0u6XXRNwAGf2hXz5BWkSaI187c01eCHPu0aKg4lHQiQZKsnoyAOgI2p2Tfp
 v7URSCGOasb2ARX4+7PuAGHDo0z1R/djDG43tryq+Wx6SUDXNJ9Hta6D9jF03WjLr2ct88Z58
 Xae81iCjASLopXv/W57F+0cvq1IKRU1mR5Mjqyd9NQTu/a+ij+johRZrUSqEmYoYCbUu17/kq
 sS4wI98iKYSyJ2dUaBciIkxlb9c4rmuey+U3h2Ex00VaoueIH0=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -1153,6 +1150,14 @@ static int snd_via82xx_create(struct snd_card *card,
>>  
>>  	*r_via = chip;
>>  	return 0;
>> +
>> +disable_device:
>> +	pci_disable_device(pci);
>> +	goto exit;
>> +free_chip:
>> +	snd_via82xx_free(chip);
>> +exit:
>> +	return err;
> 
> Doubly goto doesn't look like an improvement.

Would you like to integrate another software update with the statement
“return err;” instead of “goto exit;” at this place?

Regards,
Markus