From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431163CCFD8 for ; Wed, 18 Mar 2026 11:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773831726; cv=none; b=u0LmkRs4ING5T9PzIq8/Ju8iySIJhQTt5oWwolBrMxuLueCEqYjNhgy9GFxiRPuJqJSTQoF9+tsV+BUl61mtVqm2kDv2dXUrpKWDbr8lg2BZ/zNtlYJUmXHZgN+MSbQMvOdrrja/U/mdN/g8ftZ4lmI4NUknLhZpuDn4crXajhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773831726; c=relaxed/simple; bh=mXGG3fi1msKr1rqOQEhDZU3z+5KSHVjYfE0PBeEdliA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pn4WO4ZGnI0SUNrtzoIPTK3OehNtNGvmQVOuIfRSunUOuYcK0/aEz9+SACEdFbVTvAWGnGfilPyIikVDsF7mRH9axFxuzfBwMcWlsxImuNDlW/TwlpqjoIkLVScTGJiM2bSzdKeL52wJUc6on8B0q+hJXOGKs1jEozI4RWgIKmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FCXeVVWj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MgbgQ3Y6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FCXeVVWj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MgbgQ3Y6" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I9021k2730171 for ; Wed, 18 Mar 2026 11:02:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QrvGnIZXPty4XETU1uqiYV3wUNDHCuw5A8GY7KhrLtc=; b=FCXeVVWjn8MH0Txl zLd+DoQhHIMImA0493MCbUW5ys5fc+W/Zn9K2t8BTBNxu8cZZW8DP7kivsTqexzF sFg94IwvGa69YScvLtzZR1vSkdqTYaSKJZbM/cIuoQIz37QrntVmQCwKDRmqH0/I JW6kt/Q35IWGYfZm3PC93roCoioMTkxsFwE2hhGOUnkD+jfP56ZIJJiav5LCUCi8 dg4doBc5gHytpfBLjyiuHI1YGZG9RgD35jIzPFuKtN7zb+aw/q16C3cYcovCPAl8 yS7is1nbkqQnvewuD/0uL+fZ8kXUlabT1ZZW17yXSwibHA73hXkTlXRJkkh8K0N0 w5YuaQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy8kjvgmk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 11:02:02 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82a18d37a91so3327578b3a.3 for ; Wed, 18 Mar 2026 04:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773831721; x=1774436521; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QrvGnIZXPty4XETU1uqiYV3wUNDHCuw5A8GY7KhrLtc=; b=MgbgQ3Y6aEikGVWYLrAgXHtQnapwG7fDDvwNL04NG7Lu777HTgslXrTL+Wiv89osFV yWF++Ph6j42rd+WUIp0am3qtvWmbBx2HwjWWE65chK7tguQRKCmFi7Uw5Dca4VVjyrFw pxzhjyGWqjnDXQ6REBEkCYB8RJS7PPftUHI+2WNHoXgYxbxHej7FHlKW8DyCJnj4ZJeQ jvm0yVSXuO6y8mfQjd99q8WEQpYwy8aB7XcsVp5EjwBJclQ8PHb1nPduMijNcR1TEcqf s/azdexbsxQZZHZeRGYvMV2uuLjqtt6q6fd68t5V3rhZg2qtDgfutvaNEzouSdi3AmAx Joow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773831721; x=1774436521; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QrvGnIZXPty4XETU1uqiYV3wUNDHCuw5A8GY7KhrLtc=; b=G40+6QhEil208JzLo1eKwW0HbHDCtQiyomQsWbuhybDIGEKCNJWrDobtL8U87gGRJh c92Z6Ip/qtOdCRTe1Hjfkep9gORqEkxFuSNKokEzLOKfUDqLFU0aryiJBSrOMaH5cI6V NBaLmW3Jnn93Exr2UrnzZLQx+HFYNL3TXOGW/okXE4IAyQzq+iXsE82Ra+Bufzx1J4sv 0LY2RGeN64bqsTl5epLUz75EsKJhgx2tEJPu45NX+oxkos/A5pcS8ZnbXlhG6DmCmB3R 1Gx9y2kF7wk+Gqmlqd7MhfXW/omuZP6647moCEDiai0PT/6DqCOv9ghWU+Dz3L71+pcJ g39w== X-Forwarded-Encrypted: i=1; AJvYcCW9MoaV1lcrAQaw/44ymP4vdP75vingtnsDGwKJGuKgrI1DivjpWiwSDviJmcfVCm7evA5Mj8WKXtsMHlc=@vger.kernel.org X-Gm-Message-State: AOJu0YxYGUpG8/l+T+2Ck1y4P3xQ2j3M5NymAJnG5aPgmH4K4RFQsIZq x2cBzqVKYgBzETsCOb04pLRrVorlb6SwdD7Ph0dbJH74dEWnKwSB60swPFZzr+IvcZbgltonyYW ydIe02X4o0ZCFVLNF1IIXPUQya4XihsnEI+6VVytaPZrmLO1fusVjPEHPg8+vOsP1Agc= X-Gm-Gg: ATEYQzz3AoI7wRNx/FSmXuqmYYS6x5oxSWVbjj2e7LGdi1uQkcXRLAMifVeKaiyvs+c k/E6EXAEziJmX2ml9/PdC29MB1DPGaKD3eoV54Fs2QZqu3UIq9pk9Z7vrJqmeSaOmsusAvxRmul rdZAiZGofr/nuwN3J2C9oUvO7jGiEtVhACbAhs9eAJHGFjSU9sBbZUszo/3oMbg9/50S4PWF8DQ PjxaRvElsHU3uOvra28MH7vAMhVeNU4R4se6tAtIZmc9uh2XLwTKkIeR2V6a6pQKcXZa1b8JBm2 SMPxF9UrKMhnMGX2r4v9jkF3xtv2tlf4bR+ZPapTFehbVrWNuRvViaItN6bQ7d7Ggt7jQwM0w6v FgHzXY/R6JD/LkPLJnDd+vRrdLUijxzWR45BDYj+KvvAnSF8nyVB6VQ== X-Received: by 2002:a05:6a00:398e:b0:829:8c23:f706 with SMTP id d2e1a72fcca58-82a6af3570dmr2770310b3a.46.1773831721282; Wed, 18 Mar 2026 04:02:01 -0700 (PDT) X-Received: by 2002:a05:6a00:398e:b0:829:8c23:f706 with SMTP id d2e1a72fcca58-82a6af3570dmr2770265b3a.46.1773831720697; Wed, 18 Mar 2026 04:02:00 -0700 (PDT) Received: from [10.206.101.19] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6b531f35sm2450860b3a.11.2026.03.18.04.01.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 04:02:00 -0700 (PDT) Message-ID: <3a2f25b8-9859-4bbf-a4bc-996194b73fae@oss.qualcomm.com> Date: Wed, 18 Mar 2026 16:31:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/8] media: qcom: iris: use common set_preset_registers function To: Dmitry Baryshkov , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260316-iris-platform-data-v7-0-fc79f003f51c@oss.qualcomm.com> <20260316-iris-platform-data-v7-2-fc79f003f51c@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260316-iris-platform-data-v7-2-fc79f003f51c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA5MyBTYWx0ZWRfXz8i+c/IpFk6X VqFH+6Sy5KkQdKlaLt+Adfov/kV2A3eHwO0mwwQunnpgASZOsLAPn7ywSh85El6xB9KSaGa74wh Bi/SHI1BCtATlNMjBDxGxMY7MlL9K5LpomeOoC6P0c4QQ/BAzlcYS2HdKLF02zcap8R8XLlTUY6 Mfze19CRV01IlmowEVqbQrSG0iOUfj+QxWu7HOQN8uV5mEIHLM0768KC37SHHAAjQ81Y5EiC81Z OARzEVOi0jnbONdgUUEQukqaxt+xCO2KFs4xxHyWSr2irEzqA+NLz+Vbo35Y4EgyKSkGN4qbaLt EnMrbLSczyQ8cFb/UN5p3JARuaZ7vkKxX4IZ5WZ8k7D5np9WGcHz9//39L56LVgEcMZbpmYTMSI EgxyhqyLPFoyeCxPnlNXecm8jCI/NycuBjNZEYX9VBbMk9qH5sqh1nsMR2pG3598HiAO/EW2De/ TOHguP0AaPL3HEYIHpg== X-Authority-Analysis: v=2.4 cv=P8I3RyAu c=1 sm=1 tr=0 ts=69ba862a cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=xm1I8ePgU3ACQa9n1MUA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: fj1UL-qCbOIUDIW5OpFFoNMaqHusQWwR X-Proofpoint-GUID: fj1UL-qCbOIUDIW5OpFFoNMaqHusQWwR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180093 On 3/17/2026 12:24 AM, Dmitry Baryshkov wrote: > The set_preset_registers is (currently) common to all supported devices. > Extract it to a iris_vpu_common.c and call it directly from > iris_vpu_power_on(). Later, if any of the devices requires special > handling, it can be sorted out separately. > > Reviewed-by: Dikshita Agarwal > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Vikash Garodia