From: Li Hong <lihong.hi@gmail.com>
To: Borislav Petkov <borislav.petkov@amd.com>
Cc: Doug Thompson <dougthompson@xmission.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amd64_edac: fix a wrong goto clause in amd64_edac.c
Date: Tue, 20 Oct 2009 09:39:21 +0800 [thread overview]
Message-ID: <3a3680030910191839g192514bbhfee4612d081ccd86@mail.gmail.com> (raw)
In-Reply-To: <20091019125212.GA20983@aftab>
Just caught by looking at the code. Thanks.
2009/10/19 Borislav Petkov <borislav.petkov@amd.com>:
> On Mon, Oct 19, 2009 at 04:33:29PM +0800, Li Hong wrote:
>> In amd64_edac_init(void) in amd64_edac.c, cache_k8_northbridges() is called
>> before pci_register_driver. If it fails, should exit with err directly.
>>
>> Signed-off-by: Li Hong <lihong.hi@gmail.com>
>
> Thanks, queued for the next .32 update.
>
> By the way, is this something you've caught by looking at the code
> or is it a condition you're hitting on a real system with a specific
> workload? If it is the second, I'd like to know more wrt to why
> cache_k8_northbridges() is failing in your particular case.
>
> Thanks.
>
> --
> Regards/Gruss,
> Boris.
>
> Operating | Advanced Micro Devices GmbH
> System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
> Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
> Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
> (OSRC) | Registergericht München, HRB Nr. 43632
>
>
next prev parent reply other threads:[~2009-10-20 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 8:33 Li Hong
2009-10-19 12:52 ` Borislav Petkov
2009-10-20 1:39 ` Li Hong [this message]
2009-10-19 14:58 ` Doug Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a3680030910191839g192514bbhfee4612d081ccd86@mail.gmail.com \
--to=lihong.hi@gmail.com \
--cc=borislav.petkov@amd.com \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®