From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C37F7285050 for ; Tue, 19 May 2026 10:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779188019; cv=none; b=f3MNwFU4RfhzMs+0pn2RYqkHKicAe/mkak+OIpdQGDPqDOat4SbnWXYfGzi3EuNoUp640GFxdYqbVEmAOYY9UISxob3KFPQCHJLX8UHtu8a3ZebN61TTkD8OhG5uce8goPf/XOutWOHp1Uy7MgYrhW9nVjJtOkNFQOSBuE1CUy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779188019; c=relaxed/simple; bh=UYOSZYHFO2lZQJ0YtPqaAa6+5g7gsS3w6AdB4rm7P1s=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=svRwJ/Lbl6EpJO6GqCRzMdjiIudG4R6eg6flBuNZdzUGqRNZ0m7lr7JX52wKE7C92Lq/BH5NHeJPLZiYao8MEykiNs2AvFGoMtk3nVSklSTncQ4qid4vEoUBNs0BPDdRowkbNMETtRyIV8A1WPCmPrPEEEMxZnTtwig5HgOY768= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JNC+nfzh; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qcYnXmmR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JNC+nfzh"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qcYnXmmR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779188016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AUFo6hIuf2ZxDrSoEBKNJqzPv5wXEukq1eF4NrWaHmc=; b=JNC+nfzheTr4WAmh5BlGneG8TLTC79RKGcO6OLQdBIPTNBdHTIyjobjYzOXO0mRDb2lRCe hHzMpAsSGX3WLJSd6xu/rNHUWznJxNFGdCrLn6hH3VGdgJBOBoTspxLUxvo4p36GRcDTub BHeFcaklVho9v+janbCcutbo1IUVS4w= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-L00WFy-XMnWHDsC41c6H6w-1; Tue, 19 May 2026 06:53:35 -0400 X-MC-Unique: L00WFy-XMnWHDsC41c6H6w-1 X-Mimecast-MFC-AGG-ID: L00WFy-XMnWHDsC41c6H6w_1779188014 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fd396daedso22177325e9.0 for ; Tue, 19 May 2026 03:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779188014; x=1779792814; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=AUFo6hIuf2ZxDrSoEBKNJqzPv5wXEukq1eF4NrWaHmc=; b=qcYnXmmRd3s/lLivY1ajFkQnee3+G/k1U9IVBXT5FsUic4g92SQOanjIBs+0AGHF0H 6OMMbUHn5c0ckJxhVUPfadQ5OaLbtJ6DwvbWW9nonK6DqB17E7d13wyN91i/iOSYvk7c p759nJX9sUL6GDTh2W71ZntFdhGbP3C+BGegIKWWtsgtB0VVSgWpMICB0F3QcSXCUlr8 czkjpqcjc0g0MvBRTFGHBXWkE+NtCt2qNQHs1r+gYV6Yk4imcBpulL0KFt7fX/Ol5fI1 6A/giigWNCSv6Cah+VxLokskLzGTwvb/Ei1d7Egq5oHJ+DGouwXtKLynDU56h1YWRlkc K+EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779188014; x=1779792814; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AUFo6hIuf2ZxDrSoEBKNJqzPv5wXEukq1eF4NrWaHmc=; b=FFEW/6K1APlUiaBaEbl4iew0hLUncIKhFmPEbBSI2kSeAZwbA90e04XWFcMf7PzFW1 w2RpCALTMYeORGygyoocffwosv4erUm2ohbQMxR+sAOnarGSHvmm2qHjCct1QmJFAsNL JSxhVOeVCsDcF2RySYCEECKdQ80lNCD7TU5hWEJp0L4zmUjoYdQrEORVkqDNgLNxQMDT 9yTdmhR2YwrhmCdmu7d+nyVthVc/TpEqQxJZwP2436liYJwvUUy0ux2eCoOGbxBTFu91 hwMiWTNyEpVKivh6jcUhS2Lv/ffqIx2yV2VKV5UYyjOCQseOOUtyWH4e6Mf6qrhUQOa8 e4Zg== X-Forwarded-Encrypted: i=1; AFNElJ9ayKMnZjHAXSTeOLyZW0yNPcifLVcQEH0VH4HBXQP6WvWzdmSyL/C6aP1MDO1dkYjfC+ycgMZeUWpztWk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe4BMbdzxzPB5WzQ5BPaS+DqtI4mNW2pTRoLDSwoFa1SLIkPD1 0xZEu1ostKrtOhXbrZp7cTNc3aS47FpkVvCava041LEeSpJOBX+XhZc/Pl6OUnmhP96CNs8ypsv RA0jqFHCqGCXUSMu0ttzZQmtuO7H/kNEIHIPPkYOI6aFS+AdxVqThi3Z34igg8g3RCA== X-Gm-Gg: Acq92OEM64GALkB3bilqLxk0eWSQYkDDEqWKTgPe1C7k1z0+MSYQHGAD0DfGs5AVP3V JvT23Ku4wCglp0VzWFK1Nc9dL8JSZiIFzz8vyvwQi8QG3RJDbBwNn5tVfgu7/BNN6pgJxfglotF tCXr7ZEnybkB9kZnkgnQYl7G91ZvGDHmo25Ng+cKqx4LOg/Fl1Z6uXZ5MwD7cSluzuO8N3AFxxc mJbN9BOUA25uRKc/QBxdoKrtgnc1xb3J4WOEamAMVrgGg21vUDi/kCYM5jsup05Ers1EFUkgDZY mL38STu9hy552x6zCL5LNE+G0pN6B25SQQK1Pdp2S5oh34MoF4iBXwPGmkIG0Ozs19vlKX8ZKWr /eUHPB5bZ3l4bTCm8/VSCIue7RroJxphdQHHJy1iXDgYARINeqQ/Sb7NEiYqKT2ZvFw== X-Received: by 2002:a05:600c:8b45:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-48fe63253f3mr282542355e9.21.1779188014439; Tue, 19 May 2026 03:53:34 -0700 (PDT) X-Received: by 2002:a05:600c:8b45:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-48fe63253f3mr282541945e9.21.1779188014000; Tue, 19 May 2026 03:53:34 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe78aadsm101525975e9.29.2026.05.19.03.53.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 03:53:33 -0700 (PDT) Message-ID: <3a390dee-38e9-4df1-a94d-7128cd4eb834@redhat.com> Date: Tue, 19 May 2026 12:53:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 4/5] net: dsa: mt7530: clear flood flags on bridge leave To: Daniel Golle , "Chester A. Unal" , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Matthias Brugger , AngeloGioacchino Del Regno , DENG Qingfang , Florian Fainelli , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Sean Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: From: Paolo Abeni Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/14/26 4:05 PM, Daniel Golle wrote: > Flood flags set by port_bridge_flags persist after a port leaves the > bridge, causing unknown unicast to be forwarded to standalone ports. > > Clear UNU_FFP, UNM_FFP and BC_FFP in port_bridge_leave so that the > port returns to its initial state without flooding. > > Fixes: 5a30833b9a16 ("net: dsa: mt7530: support MDB and bridge flag operations") > Signed-off-by: Daniel Golle > --- > v2: no changes > > drivers/net/dsa/mt7530.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 752ba92b0851..5b58e42bfda9 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -1767,6 +1767,11 @@ mt7530_port_bridge_leave(struct dsa_switch *ds, int port, > mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK, > MT7530_PORT_MATRIX_MODE); > > + /* Clear flood flags so they don't persist across bridge leave */ > + mt7530_clear(priv, MT753X_MFC, > + UNU_FFP(BIT(port)) | UNM_FFP(BIT(port)) | > + BC_FFP(BIT(port))); I think sashiko has a point here: --- Will these cleared flags be immediately overwritten by the DSA core? When a port leaves a bridge, the DSA core's dsa_port_bridge_leave() broadcasts the DSA_NOTIFIER_BRIDGE_LEAVE event, which triggers this callback and clears the bits. However, immediately after the broadcast returns, dsa_port_bridge_leave() unconditionally calls dsa_port_switchdev_unsync_attrs(), which calls dsa_port_clear_brport_flags(). This explicitly configures standalone ports to flood everything by setting the BR_FLOOD, BR_MCAST_FLOOD, and BR_BCAST_FLOOD flags to 1, and then invokes the driver's port_bridge_flags callback. As a result, mt7530_port_bridge_flags() processes this call and executes mt7530_rmw() to turn the UNU_FFP, UNM_FFP, and BC_FFP bits right back to 1 for the port. Does this leave the isolation bug unfixed since the register clearing is reverted before the DSA bridge leave sequence fully completes? --- Since the other fixes are independent, I'm applying them. /P